LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH -next] hwmon: fix gpio-fan.c build
@ 2015-03-10 23:42 Randy Dunlap
2015-03-11 2:14 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2015-03-10 23:42 UTC (permalink / raw)
To: LKML, lm-sensors; +Cc: Jean Delvare, Guenter Roeck, Simon Guinot
From: Randy Dunlap <rdunlap@infradead.org>
Fix build error when CONFIG_THERMAL=m and SENSORS_GPIO_FAN=y
by preventing that combination.
Fixes these build errors:
drivers/built-in.o: In function `gpio_fan_remove':
gpio-fan.c:(.text+0x21e97e): undefined reference to `thermal_cooling_device_unregister'
drivers/built-in.o: In function `gpio_fan_probe':
gpio-fan.c:(.text+0x21efbc): undefined reference to `thermal_cooling_device_register'
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Jean Delvare <jdelvare@suse.de>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: lm-sensors@lm-sensors.org
Cc: Simon Guinot <sguinot@lacie.com>
---
drivers/hwmon/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20150310.orig/drivers/hwmon/Kconfig
+++ linux-next-20150310/drivers/hwmon/Kconfig
@@ -510,6 +510,7 @@ config SENSORS_G762
config SENSORS_GPIO_FAN
tristate "GPIO fan"
depends on GPIOLIB
+ depends on THERMAL || THERMAL=n
help
If you say yes here you get support for fans connected to GPIO lines.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next] hwmon: fix gpio-fan.c build
2015-03-10 23:42 [PATCH -next] hwmon: fix gpio-fan.c build Randy Dunlap
@ 2015-03-11 2:14 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2015-03-11 2:14 UTC (permalink / raw)
To: Randy Dunlap, LKML, lm-sensors; +Cc: Jean Delvare, Simon Guinot
On 03/10/2015 04:42 PM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix build error when CONFIG_THERMAL=m and SENSORS_GPIO_FAN=y
> by preventing that combination.
>
> Fixes these build errors:
>
> drivers/built-in.o: In function `gpio_fan_remove':
> gpio-fan.c:(.text+0x21e97e): undefined reference to `thermal_cooling_device_unregister'
> drivers/built-in.o: In function `gpio_fan_probe':
> gpio-fan.c:(.text+0x21efbc): undefined reference to `thermal_cooling_device_register'
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Jean Delvare <jdelvare@suse.de>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: lm-sensors@lm-sensors.org
> Cc: Simon Guinot <sguinot@lacie.com>
> ---
> drivers/hwmon/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20150310.orig/drivers/hwmon/Kconfig
> +++ linux-next-20150310/drivers/hwmon/Kconfig
> @@ -510,6 +510,7 @@ config SENSORS_G762
> config SENSORS_GPIO_FAN
> tristate "GPIO fan"
> depends on GPIOLIB
> + depends on THERMAL || THERMAL=n
> help
> If you say yes here you get support for fans connected to GPIO lines.
>
>
Applied, thanks.
I really have to add that combination to my build tests :-(
Guenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-11 2:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-10 23:42 [PATCH -next] hwmon: fix gpio-fan.c build Randy Dunlap
2015-03-11 2:14 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).