From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753834AbbCKP2g (ORCPT ); Wed, 11 Mar 2015 11:28:36 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:51497 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753788AbbCKP2c (ORCPT ); Wed, 11 Mar 2015 11:28:32 -0400 Message-ID: <55005F0F.5080302@ti.com> Date: Wed, 11 Mar 2015 11:28:15 -0400 From: Murali Karicheri User-Agent: Mozilla/5.0 (X11; Linux i686; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Russell King - ARM Linux CC: Rob Herring , Grant Likely , Rob Herring , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-pci@vger.kernel.org" , Bjorn Helgaas , Arnd Bergmann , Suravee Suthikulanit , Will Deacon , Joerg Roedel Subject: Re: [PATCH] pci: of : fix BUG: unable to handle kernel References: <1426001139-18419-1-git-send-email-m-karicheri2@ti.com> <20150311124911.GA8656@n2100.arm.linux.org.uk> In-Reply-To: <20150311124911.GA8656@n2100.arm.linux.org.uk> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/11/2015 08:49 AM, Russell King - ARM Linux wrote: > On Wed, Mar 11, 2015 at 07:35:45AM -0500, Rob Herring wrote: >> On Tue, Mar 10, 2015 at 10:25 AM, Murali Karicheri wrote: >>> On some platforms such as that based on x86, ia64 etc, root bus is >>> created with parent node passed in as NULL to pci_create_root_bus(). >>> On these platforms, the patch series "PCI: get DMA configuration from >>> parent device" when applied causes kernel crash. So add a check for this >>> in of_pci_dma_configure() >> >> Wouldn't these arches have OF disabled and call an empty function? >> Regardless, we still need this. >> >>> Signed-off-by: Murali Karicheri >> >> I'm assuming Bjorn will apply this. >> >> Acked-by: Rob Herring > > It might be an idea to read the subject line... > > "fix BUG: unable to handle kernel" Russell, I will fix the subject as "fix BUG: unable to handle kernel NULL pointer" and re-send. Thanks Murali > > which is meaningless. It needs a much better subject line before it can > be committed. > -- Murali Karicheri Linux Kernel, Texas Instruments