LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Shuah Khan <shuahkh@osg.samsung.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linux-kernel@vger.kernel.org, davej@codemonkey.org.uk,
	mmarek@suse.cz, linux-api@vger.kernel.org
Subject: Re: [PATCH v4 2/9] kbuild: Don't pass LDFLAGS to selftest Makefile
Date: Wed, 11 Mar 2015 10:08:08 -0600	[thread overview]
Message-ID: <55006868.3020309@osg.samsung.com> (raw)
In-Reply-To: <1426046765-19289-2-git-send-email-mpe@ellerman.id.au>

On 03/10/2015 10:05 PM, Michael Ellerman wrote:
> The makefile in arch/x86/Makefile.um sets LDFLAGS and exports it, which
> is then propagated to the selftest Makefiles and leads to build errors
> there. The build errors occur because we are passing LDFLAGS to CC, but
> the option set in Makefile.um (-m elf_x86_64) is not understood by CC.
> We could fix that by using -Wl, but that might break the UM build if
> it's actually passing that option to LD directly.
> 
> We don't actually want the LDFLAGS from kbuild in the selftest Makefile,
> so the simplest fix seems to be to clear LDFLAGS before invoking the
> selftest Makefile.
> 
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index 0836e9d628f0..5cef1d4c2ea0 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1085,7 +1085,7 @@ headers_check: headers_install
>  
>  PHONY += kselftest
>  kselftest:
> -	$(Q)$(MAKE) -C tools/testing/selftests MAKEFLAGS="$(filter-out rR,$(MAKEFLAGS))" run_tests
> +	$(Q)$(MAKE) LDFLAGS= -C tools/testing/selftests MAKEFLAGS="$(filter-out rR,$(MAKEFLAGS))" run_tests
>  
>  # ---------------------------------------------------------------------------
>  # Modules
> 

Does this work on x86, powerpc, and other architectures? Do all tests
with and without explicit rules build correctly?

-- Shuah

-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978

  reply	other threads:[~2015-03-11 16:08 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-11  4:05 [PATCH v4 1/9] kbuild: Don't pass -rR to selftest makefiles Michael Ellerman
2015-03-11  4:05 ` [PATCH v4 2/9] kbuild: Don't pass LDFLAGS to selftest Makefile Michael Ellerman
2015-03-11 16:08   ` Shuah Khan [this message]
2015-03-13 18:06   ` Shuah Khan
2015-03-11  4:05 ` [PATCH v4 3/9] selftests: Introduce minimal shared logic for running tests Michael Ellerman
2015-03-13 17:19   ` Shuah Khan
2015-03-13 20:28     ` Shuah Khan
2015-03-11  4:06 ` [PATCH v4 4/9] selftests: Add install target Michael Ellerman
2015-03-11 13:18   ` Shuah Khan
2015-03-11 16:03     ` Shuah Khan
2015-03-12  3:11       ` Michael Ellerman
2015-03-12  3:15     ` Michael Ellerman
2015-03-13 16:33       ` Dave Jones
2015-03-13 17:08         ` Shuah Khan
2015-03-13 17:20   ` Shuah Khan
2015-03-13 21:32     ` Shuah Khan
2015-03-13 23:08       ` Shuah Khan
2015-03-16  3:04       ` Michael Ellerman
2015-03-16  3:12         ` Michael Ellerman
2015-03-18 14:30         ` Shuah Khan
2015-03-11  4:06 ` [PATCH v4 5/9] selftests: Add install support for the powerpc tests Michael Ellerman
2015-03-11  4:06 ` [PATCH v4 6/9] selftests: Set CC using CROSS_COMPILE once in lib.mk Michael Ellerman
2015-03-11  4:06 ` [PATCH v4 7/9] selftests/timers: Use implicit rules Michael Ellerman
2015-03-11  4:06 ` [PATCH v4 8/9] selftests/mqueue: " Michael Ellerman
2015-03-11  4:06 ` [PATCH v4 9/9] selftests/mount: " Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55006868.3020309@osg.samsung.com \
    --to=shuahkh@osg.samsung.com \
    --cc=davej@codemonkey.org.uk \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=mpe@ellerman.id.au \
    --subject='Re: [PATCH v4 2/9] kbuild: Don'\''t pass LDFLAGS to selftest Makefile' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).