LKML Archive on
help / color / mirror / Atom feed
From: David Daney <>
To: Markos Chandras <>,
	Leonid Yegoshin <>,
	David Daney <>
Subject: Re: [PATCH] Revert "MIPS: mm: tlbex: Use cpu_has_mips_r2_exec_hazard for the EHB instruction"
Date: Wed, 11 Mar 2015 09:51:20 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 03/11/2015 01:28 AM, Markos Chandras wrote:
> On 02/23/2015 10:52 PM, David Daney wrote:
>> From: David Daney <>
>> This reverts commit 77f3ee59ee7cfe19e0ee48d9a990c7967fbfcbed.
>> There are two problems:
>> 1) It breaks OCTEON, which will now crash in early boot with:
>>    Kernel panic - not syncing: No TLB refill handler yet (CPU type: 80)
>> 2) The logic is broken.
>> The meaning of cpu_has_mips_r2_exec_hazard is that the EHB instruction
>> is required.  The offending patch attempts (and fails) to change the
>> meaning to be that EHB is part of the ISA.
>> Signed-off-by: David Daney <>
>> ---
> Hi,
> First of all sorry about the octeon breakage.
> However, whilst this patch will fix Octeon it will break R6

But breaking R6 is not a regression, breaking OCTEON is.  For new code, 
there is this bit of asymmetry.

> Can we please consider another patch that will simply use
> cpu_has_mips_r2_r6 instead of cpu_has_mips_r2 so both will work in 4.0?

If you have a patch that fixes the problem properly, please post it for 

David Daney

      reply	other threads:[~2015-03-11 16:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-23 22:52 David Daney
2015-02-24  1:10 ` Maciej W. Rozycki
2015-03-11  8:28 ` Markos Chandras
2015-03-11 16:51   ` David Daney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] Revert "MIPS: mm: tlbex: Use cpu_has_mips_r2_exec_hazard for the EHB instruction"' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).