From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753582AbbCMK2X (ORCPT ); Fri, 13 Mar 2015 06:28:23 -0400 Received: from smtp89.iad3a.emailsrvr.com ([173.203.187.89]:35650 "EHLO smtp89.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750890AbbCMK2U (ORCPT ); Fri, 13 Mar 2015 06:28:20 -0400 X-Sender-Id: abbotti@mev.co.uk Message-ID: <5502BBC1.2000702@mev.co.uk> Date: Fri, 13 Mar 2015 10:28:17 +0000 From: Ian Abbott User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.5.0 MIME-Version: 1.0 To: Joe Perches CC: driverdev-devel@linuxdriverproject.org, Greg Kroah-Hartman , H Hartley Sweeten , linux-kernel@vger.kernel.org Subject: Re: [PATCH 00/56] staging: comedi: introduce comedi_pci.h header References: <1426003875-27653-1-git-send-email-abbotti@mev.co.uk> <1426004716.18060.10.camel@perches.com> <55016A81.1000801@mev.co.uk> In-Reply-To: <55016A81.1000801@mev.co.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/03/15 10:29, Ian Abbott wrote: > On 10/03/15 16:25, Joe Perches wrote: >> On Tue, 2015-03-10 at 16:10 +0000, Ian Abbott wrote: >>> "comedidev.h" includes PCI-specific stuff that gets included by all >>> comedi drivers including non-PCI ones. Separate it out into its own >>> header "comedi_pci.h". Make the new header include and >>> "comedidev.h" so that comedi PCI drivers do not need to include them >>> explicitly. >> >> Isn't the kernel progressing to avoid indirect includes? > > I could do it that way if you think it would help. Better to redo it > before it is committed than after. I have a v2 series ready to post now, that doesn't use the indirect includes. Should I post that one, Greg, or are you okay with the existing series? -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-