LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Peter Hung <hpeter@gmail.com>
To: Johan Hovold <johan@kernel.org>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org, tom_tsai@fintek.com.tw,
	peter_hong@fintek.com.tw,
	Peter Hung <hpeter+linux_kernel@gmail.com>
Subject: Re: [PATCH V8 02/10] USB: f81232: implement RX bulk-in EP
Date: Mon, 16 Mar 2015 10:53:38 +0800	[thread overview]
Message-ID: <550645B2.1090202@gmail.com> (raw)
In-Reply-To: <20150314114845.GC9442@localhost>

Hello,

Johan Hovold 於 2015/3/14 下午 07:48 寫道:
> On Thu, Feb 26, 2015 at 06:02:08PM +0800, Peter Hung wrote:
>> -	if (!urb->actual_length)
>> +	if ((urb->actual_length < 2) || (urb->actual_length % 2))
>>   		return;
>
> Not parsing short data (e.g. not divisible by 2) is OK I guess. You
> could also just discard the last odd byte, but that's up to you.
>
> Either way, I think you should add a dev_warn here rather than just
> silently drop it.

With F81232, when it first submit with interrupt URB, it will response 
once with 1 bytes data. The data is hw current LSR, but it useless on 
open. It's should necessary with receiving data. When the device is 
working good, it's should acked with even size data.

To avoid confusing to user, I'll keep it without warning message.

Thanks
-- 
With Best Regards,
Peter Hung

  reply	other threads:[~2015-03-16  2:53 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-26 10:02 [PATCH V8 00/10] USB: f81232: V8 patches Peter Hung
2015-02-26 10:02 ` [PATCH V8 01/10] USB: f81232: rename private struct member name Peter Hung
2015-02-26 10:02 ` [PATCH V8 02/10] USB: f81232: implement RX bulk-in EP Peter Hung
2015-03-14 11:48   ` Johan Hovold
2015-03-16  2:53     ` Peter Hung [this message]
2015-03-16  8:52       ` Johan Hovold
2015-03-16  9:15         ` Peter Hung
2015-02-26 10:02 ` [PATCH V8 03/10] USB: f81232: change lock mechanism Peter Hung
2015-02-26 10:02 ` [PATCH V8 04/10] USB: f81232: implement read IIR/MSR with endpoint Peter Hung
2015-03-14 12:02   ` Johan Hovold
2015-03-16  3:08     ` Peter Hung
2015-03-16  8:55       ` Johan Hovold
2015-03-16  9:18         ` Peter Hung
2015-02-26 10:02 ` [PATCH V8 05/10] USB: f81232: implement MCR/MSR function Peter Hung
2015-03-14 12:09   ` Johan Hovold
2015-02-26 10:02 ` [PATCH V8 06/10] USB: f81232: implement port enable/disable method Peter Hung
2015-02-26 10:02 ` [PATCH V8 07/10] USB: f81232: implement set_termios() Peter Hung
2015-03-14 12:24   ` Johan Hovold
2015-02-26 10:02 ` [PATCH V8 08/10] USB: f81232: clarify f81232_ioctl() and fix Peter Hung
2015-03-14 12:27   ` Johan Hovold
2015-02-26 10:02 ` [PATCH V8 09/10] USB: f81232: cleanup non-used define Peter Hung
2015-02-26 10:02 ` [PATCH V8 10/10] USB: f81232: modify/add author Peter Hung
2015-03-05  5:59 ` [PATCH V8 00/10] USB: f81232: V8 patches Peter Hung
2015-03-05  7:03   ` Johan Hovold
2015-03-14 12:30     ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=550645B2.1090202@gmail.com \
    --to=hpeter@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpeter+linux_kernel@gmail.com \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=peter_hong@fintek.com.tw \
    --cc=tom_tsai@fintek.com.tw \
    --subject='Re: [PATCH V8 02/10] USB: f81232: implement RX bulk-in EP' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).