LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] mfd: twl6040: match wait_for_completion_timeout return type
@ 2015-03-16  8:17 Nicholas Mc Guire
  2015-03-16 10:48 ` Peter Ujfalusi
  0 siblings, 1 reply; 2+ messages in thread
From: Nicholas Mc Guire @ 2015-03-16  8:17 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: Samuel Ortiz, Lee Jones, linux-omap, linux-kernel, Nicholas Mc Guire

Return type of wait_for_completion_timeout is unsigned long not int. As
time_left is exclusively used for wait_for_completion_timeout here its
type is simply changed to unsigned long.

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
---

Patch was compile tested with x86_64_defconfig + CONFIG_TWL6040_CORE=y

Patch is against 4.0-rc3 (localversion-next is -next-20150316)

 drivers/mfd/twl6040.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/twl6040.c b/drivers/mfd/twl6040.c
index f71ee3d..d6f9761 100644
--- a/drivers/mfd/twl6040.c
+++ b/drivers/mfd/twl6040.c
@@ -259,7 +259,7 @@ static irqreturn_t twl6040_thint_handler(int irq, void *data)
 
 static int twl6040_power_up_automatic(struct twl6040 *twl6040)
 {
-	int time_left;
+	unsigned long time_left;
 
 	gpio_set_value(twl6040->audpwron, 1);
 
-- 
1.7.10.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] mfd: twl6040: match wait_for_completion_timeout return type
  2015-03-16  8:17 [PATCH] mfd: twl6040: match wait_for_completion_timeout return type Nicholas Mc Guire
@ 2015-03-16 10:48 ` Peter Ujfalusi
  0 siblings, 0 replies; 2+ messages in thread
From: Peter Ujfalusi @ 2015-03-16 10:48 UTC (permalink / raw)
  To: Nicholas Mc Guire, Tony Lindgren
  Cc: Samuel Ortiz, Lee Jones, linux-omap, linux-kernel

On 03/16/2015 10:17 AM, Nicholas Mc Guire wrote:
> Return type of wait_for_completion_timeout is unsigned long not int. As
> time_left is exclusively used for wait_for_completion_timeout here its
> type is simply changed to unsigned long.

Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>

> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> ---
> 
> Patch was compile tested with x86_64_defconfig + CONFIG_TWL6040_CORE=y
> 
> Patch is against 4.0-rc3 (localversion-next is -next-20150316)
> 
>  drivers/mfd/twl6040.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/twl6040.c b/drivers/mfd/twl6040.c
> index f71ee3d..d6f9761 100644
> --- a/drivers/mfd/twl6040.c
> +++ b/drivers/mfd/twl6040.c
> @@ -259,7 +259,7 @@ static irqreturn_t twl6040_thint_handler(int irq, void *data)
>  
>  static int twl6040_power_up_automatic(struct twl6040 *twl6040)
>  {
> -	int time_left;
> +	unsigned long time_left;
>  
>  	gpio_set_value(twl6040->audpwron, 1);
>  
> 


-- 
Péter

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-03-16 10:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-16  8:17 [PATCH] mfd: twl6040: match wait_for_completion_timeout return type Nicholas Mc Guire
2015-03-16 10:48 ` Peter Ujfalusi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).