LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
To: Jeff Mahoney <jeffm@suse.com>, reiserfs-devel@vger.kernel.org
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: reiserfs: inconsistent format in __RASSERT
Date: Mon, 16 Mar 2015 21:18:20 +0800	[thread overview]
Message-ID: <5506D81C.50805@m4x.org> (raw)
In-Reply-To: <5506D504.7040800@suse.com>

On 03/16/2015 09:05 PM, Jeff Mahoney wrote:
> On 3/16/15 8:55 AM, Nicolas Iooss wrote:
>> * I missed something in my analysis and in fact the PID argument
>> is processed by reiserfs_panic (don't know where), or * the PID
>> argument is not used and should be removed, or
> 
> This, please. reiserfs_panic calls BUG(), which will contain the PID.

Whoo, thanks for the quick answer.  I will send a patch as soon as possible.

>> * the PID is useful and "[%i]" should be added somewhere in the
>> format string.
> 
>> Which one would you prefer?
> 
>> Also, I found this when building the kernel with "allmodconfig" on 
>> x86_64.  With "defconfig" gcc does not report this error, but I
>> guess it is because without CONFIG_REISERFS_CHECK, __RASSERT is
>> never used.
> 
> Yeah. If reiserfs was more actively maintained, what is currently
> protected by CONFIG_REISERFS_CHECK would be handled a bit better.
> There are ton of fsfuzzer bugs that would be caught by it and should
> be handled using reiserfs_error. Unfortunately, it also enables some
> heavy checks that make the file system very slow.
> 
> Thanks for looking into this. It looks like it's been broken for a
> while. I suppose the only saving grace is that it would crash in a
> path that crashes on purpose a few lines later.

Yes, and this is also why I believe this bug is not a security issue nor
something which needs an urgent fix.

Thanks,

Nicolas

  reply	other threads:[~2015-03-16 13:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-16 12:55 Nicolas Iooss
2015-03-16 13:05 ` Jeff Mahoney
2015-03-16 13:18   ` Nicolas Iooss [this message]
2015-03-16 13:45     ` [PATCH] reiserfs: fix __RASSERT format string Nicolas Iooss
2015-03-17 14:26       ` Jeff Mahoney
2015-03-17 15:22         ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5506D81C.50805@m4x.org \
    --to=nicolas.iooss_linux@m4x.org \
    --cc=jeffm@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=reiserfs-devel@vger.kernel.org \
    --subject='Re: reiserfs: inconsistent format in __RASSERT' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).