From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753485AbbCQCB5 (ORCPT ); Mon, 16 Mar 2015 22:01:57 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:51859 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750852AbbCQCBy (ORCPT ); Mon, 16 Mar 2015 22:01:54 -0400 X-AuditID: cbfee68f-f791c6d000004834-c4-55078b0f6610 Message-id: <55078B0F.1040800@samsung.com> Date: Tue, 17 Mar 2015 11:01:51 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-version: 1.0 To: "Ivan T. Ivanov" Cc: Roger Quadros , myungjoo.ham@samsung.com, balbi@ti.com, tony@atomide.com, nsekhar@ti.com, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 1/1] extcon: usb-gpio: Introduce gpio usb extcon driver References: <1422274532-9488-1-git-send-email-rogerq@ti.com> <1422274532-9488-2-git-send-email-rogerq@ti.com> <54C8D2F4.9050404@ti.com> <54CF4FC7.2050309@ti.com> <1426509149.2330.5.camel@linaro.org> <5506D675.8010006@ti.com> <1426515811.2330.16.camel@linaro.org> In-reply-to: <1426515811.2330.16.camel@linaro.org> Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrIIsWRmVeSWpSXmKPExsWyRsSkUJe/mz3UoOe/scXB+/UW84+cY7W4 PH8mu8XlXXPYLGYv6WexWLSsldniduMKNov9vRuYLHoeaVnsv+LlwOXx7eskFo871/awefRt WcXocfzGdiaPz5vkAlijuGxSUnMyy1KL9O0SuDIer5/LWrBSqOL7daEGxlV8XYycHBICJhIn e2azQthiEhfurWfrYuTiEBJYyihxYdVdFpiiN5P7WSAS0xkl2i+8gnJeM0osOXGXHaSKV0BL YnPzcjCbRUBVYtXt1WBj2YDi+1/cYAOxRQXCJFZOv8ICUS8o8WPyPTBbREBXYkL/PWaQocwC jxglZi6aAdYsLOAn0bLpDdRNPUwSd6//ApvEKWAk8b2jD2wbs4C6xKR5i5ghbHmJzWvegk2S ELjGLjFp/3JmiJMEJL5NPgS0jgMoISux6QAzxG+SEgdX3GCZwCg2C8lRs5CMnYVk7AJG5lWM oqkFyQXFSelFxnrFibnFpXnpesn5uZsYgTF5+t+z/h2Mdw9YH2IU4GBU4uFtyGMPFWJNLCuu zD3EaAp0xURmKdHkfGDk55XEGxqbGVmYmpgaG5lbmimJ8y6U+hksJJCeWJKanZpakFoUX1Sa k1p8iJGJg1OqgbHmYEtLwXSL/XdWPGjh3++SrFCk84Q956WFcGPYv8Pv7pg++VPemnjKe8tF 8ULuOQp9JtHvDbbt3sDkKx7+J8P+G+PBP9qBlgKmkyu5Y0SL9GzSW3rzz8Q5s62fwLMndPPb 1g+CO6eKZdzbvb5XadK83s3PV1mY+W46zf+i5P+6ggxZwwlSq5VYijMSDbWYi4oTAeH3bOfE AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrNIsWRmVeSWpSXmKPExsVy+t9jQV3+bvZQg3UztS0O3q+3mH/kHKvF 5fkz2S0u75rDZjF7ST+LxaJlrcwWtxtXsFns793AZNHzSMti/xUvBy6Pb18nsXjcubaHzaNv yypGj+M3tjN5fN4kF8Aa1cBok5GamJJapJCal5yfkpmXbqvkHRzvHG9qZmCoa2hpYa6kkJeY m2qr5OIToOuWmQN0k5JCWWJOKVAoILG4WEnfDtOE0BA3XQuYxghd35AguB4jAzSQsIYx4/H6 uawFK4Uqvl8XamBcxdfFyMkhIWAi8WZyPwuELSZx4d56ti5GLg4hgemMEu0XXrFAOK8ZJZac uMsOUsUroCWxuXk5mM0ioCqx6vZqVhCbDSi+/8UNNhBbVCBMYuX0KywQ9YISPybfA7NFBHQl JvTfYwYZyizwiFFi5qIZYM3CAn4SLZveQK3uYZK4e/0X2CROASOJ7x19YNuYBdQlJs1bxAxh y0tsXvOWeQKjwCwkS2YhKZuFpGwBI/MqRtHUguSC4qT0XEO94sTc4tK8dL3k/NxNjOCIfya1 g3Flg8UhRgEORiUe3oY89lAh1sSy4srcQ4wSHMxKIrzflIBCvCmJlVWpRfnxRaU5qcWHGE2B YTCRWUo0OR+YjPJK4g2NTcyMLI3MDS2MjM2VxHmV7NtChATSE0tSs1NTC1KLYPqYODilGhjF lHcfLmVp/Cd+XTggVebKp7jeLxn+Ca5xx16kxSitZ10j+9Ig593FZXfa7hkpS7zeo98u1CFy XIfL4qTztZAH97OtayKFPZ5bvfdY1r+K3zq72TZGR2GF4ZZdanedRW9PL0yp/Zn89oO03jSF fVsW+cU82lCkGC5sxhM+9XFqsvPG5E3ldUosxRmJhlrMRcWJALd1SxcOAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ivan, On 03/16/2015 11:23 PM, Ivan T. Ivanov wrote: > > Hi Roger, > > On Mon, 2015-03-16 at 15:11 +0200, Roger Quadros wrote: >> Hi Ivan, >> >> On 16/03/15 14:32, Ivan T. Ivanov wrote: >>> Hi, >>> >>> On Mon, 2015-02-02 at 12:21 +0200, Roger Quadros wrote: >>>> This driver observes the USB ID pin connected over a GPIO and >>>> updates the USB cable extcon states accordingly. >>>> >>>> The existing GPIO extcon driver is not suitable for this purpose >>>> as it needs to be taught to understand USB cable states and it >>>> can't handle more than one cable per instance. >>>> >>>> For the USB case we need to handle 2 cable states. >>>> 1) USB (attach/detach) >>>> 2) USB-HOST (attach/detach) >>>> >>>> This driver can be easily updated in the future to handle VBUS >>>> events in case it happens to be available on GPIO for any platform. >>>> >>>> Signed-off-by: Roger Quadros >>>> --- >>>> v4: >>>> - got rid of id_irqwake flag. Fail if enable/disable_irq_wake() fails >>>> - changed host cable name to "USB-HOST" >>> >>> I am sorry that I am getting a bit little late into this. >>> >>> Isn't supposed that we have to use strings defined in >>> const char extcon_cable_name[][]? >>> >>> >>>> + >>>> +/* List of detectable cables */ >>>> +enum { >>>> + EXTCON_CABLE_USB = 0, >>>> + EXTCON_CABLE_USB_HOST, >>>> + >>> >>> Same here: duplicated with enum extcon_cable_name >>> >>>> + EXTCON_CABLE_END, >>>> +}; >>>> + >>>> +static const char *usb_extcon_cable[] = { >>>> + [EXTCON_CABLE_USB] = "USB", >>>> + [EXTCON_CABLE_USB_HOST] = "USB-HOST", >>>> + NULL, >>>> +}; >> >> I'm not exactly sure how else it is supposed to work if we >> support only a subset of cables from the global extcon_cable_name[][]. > > I don't see issue that we use just 2 events. I think that we can > reuse enum extcon_cable_name and strings already defined in > extcon_cable_name[][] global variable. It is defined extern in > extcon.h file exactly for this purpose, no? 'extcon_cable_name' global variable is not used on extcon driver directly. It is just recommended cable name. I have plan to use standard cable name for extcon driver instead of that each extcon driver define the cable name. [snip] Thanks, Chanwoo Choi