LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Michel Machado <michel@digirati.com.br>
To: Oded Gabbay <oded.gabbay@amd.com>, Greg KH <gregkh@linuxfoundation.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	netdev <netdev@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Dave Airlie <airlied@gmail.com>
Subject: Re: Linux XIA - merge proposal
Date: Tue, 17 Mar 2015 08:37:27 -0400	[thread overview]
Message-ID: <55082007.4080401@digirati.com.br> (raw)
In-Reply-To: <550558E5.2030309@amd.com>

On 03/15/2015 06:03 AM, Oded Gabbay wrote:
> Hi Michel,
>
> Although I don't know you and I'm not familiar with XIA, I would like to
> encourage you to listen to Greg and continue with your efforts to
> upstream XIA.
>
> I can tell you, from my recent experience of upstreaming AMD's HSA
> driver to drm (amdkfd), that I understand your response/frustration.
> However, you need to understand that the feedback you got is not because
> the maintainers/devs don't want your code. It is because they want your
> code to be in the best shape it can be before merging it to the kernel.
> Once it is in the kernel, it is distributed to millions of people and it
> is maintained practically forever.
>
>  From my experience, the major changes that make your code better are
> usually done *before* upstreaming the code. Once the maintainers/devs
> realize that the code has reached some level of compliance with kernel
> standards, and the code can't get any better by leaving it outside the
> kernel, I'm sure they will accept the code. Especially if they will see
> that you are dedicated to improving it.
>
> Please see this enlightening post from drm maintainer, Dave Airlie,
> about trying to push code to upstream kernel:
> http://airlied.livejournal.com/80112.html
>
> It is called:
> "you have a long road to walk, but first you have to leave the house (or
> why publishing code is STEP ZERO)."
>
> BTW, I believe I was one of the reasons he wrote that post (it was
> published shortly after I published amdkfd's code) :)
>
> So bottom line, keep working on it. People gave you pointers what to do.
> Follow that and don't give up. In the end, I'm sure you will be very
> happy once the code is merged into the mainline kernel.
>
> Good luck,
>
>      Oded

Hi Oded,

    Thank you for sharing your experience. Dave Airlie's perspective 
helps. I'm going to walk the road "with a little help from friends."

[ ]'s
Michel Machado

  reply	other threads:[~2015-03-17 12:37 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-03 17:29 Michel Machado
2015-03-03 23:33 ` Eric W. Biederman
2015-03-04  0:14   ` Michel Machado
2015-03-04  0:01 ` Daniel Borkmann
2015-03-04  0:31   ` Michel Machado
2015-03-04  5:49     ` Greg KH
2015-03-04 13:01       ` Michel Machado
2015-03-05 16:31 ` Alex Elsayed
2015-03-05 18:34 ` Michel Machado
2015-03-10 17:01 ` Bjorn Helgaas
2015-03-10 17:19   ` Eric Dumazet
2015-03-10 22:01     ` Bjorn Helgaas
2015-03-13 15:26   ` Michel Machado
2015-03-15  9:37     ` Greg KH
2015-03-15 10:03       ` Oded Gabbay
2015-03-17 12:37         ` Michel Machado [this message]
2015-03-17 12:25       ` Michel Machado
2015-03-18 10:27         ` Oded Gabbay
2015-03-20 18:46           ` Michel Machado
2015-03-20 19:41             ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55082007.4080401@digirati.com.br \
    --to=michel@digirati.com.br \
    --cc=airlied@gmail.com \
    --cc=bhelgaas@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=oded.gabbay@amd.com \
    --subject='Re: Linux XIA - merge proposal' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).