From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932305AbbCQO0w (ORCPT ); Tue, 17 Mar 2015 10:26:52 -0400 Received: from cantor2.suse.de ([195.135.220.15]:51148 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752493AbbCQO0s (ORCPT ); Tue, 17 Mar 2015 10:26:48 -0400 Message-ID: <550839A4.9070608@suse.com> Date: Tue, 17 Mar 2015 10:26:44 -0400 From: Jeff Mahoney User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Nicolas Iooss CC: reiserfs-devel@vger.kernel.org, linux-kernel@vger.kernel.org, Jan Kara Subject: Re: [PATCH] reiserfs: fix __RASSERT format string References: <5506D81C.50805@m4x.org> <1426513506-30171-1-git-send-email-nicolas.iooss_linux@m4x.org> In-Reply-To: <1426513506-30171-1-git-send-email-nicolas.iooss_linux@m4x.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/16/15 9:45 AM, Nicolas Iooss wrote: > __RASSERT format string does not use the PID argument. > reiserfs_panic arguments are therefore formatted with the wrong > format specifier (for example __LINE__ with %s). This bug was > introduced when commit c3a9c2109f84 ("reiserfs: rework > reiserfs_panic") removed a "reiserfs[%i]" prefix. > > This bug is only triggered when using CONFIG_REISERFS_CHECK, > otherwise __RASSERT is never used. > > Signed-off-by: Nicolas Iooss Acked-by: Jeff Mahoney > Fixes: c3a9c2109f84 ("reiserfs: rework reiserfs_panic") --- > fs/reiserfs/reiserfs.h | 1 - 1 file changed, 1 deletion(-) > > diff --git a/fs/reiserfs/reiserfs.h b/fs/reiserfs/reiserfs.h index > bb79cddf0a1f..2adcde137c3f 100644 --- a/fs/reiserfs/reiserfs.h +++ > b/fs/reiserfs/reiserfs.h @@ -910,7 +910,6 @@ do { \ if > (!(cond)) \ reiserfs_panic(NULL, "assertion failure", "(" > #cond ") at " \ __FILE__ ":%i:%s: " format "\n", \ - > in_interrupt() ? -1 : task_pid_nr(current), \ __LINE__, __func__ , > ##args); \ } while (0) > > -- Jeff Mahoney SUSE Labs