From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933292AbbCYPKR (ORCPT ); Wed, 25 Mar 2015 11:10:17 -0400 Received: from mail-by2on0143.outbound.protection.outlook.com ([207.46.100.143]:52448 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932198AbbCYPKL (ORCPT ); Wed, 25 Mar 2015 11:10:11 -0400 X-WSS-ID: 0NLRWSJ-08-TXB-02 X-M-MSG: Message-ID: <5512CFB6.1020606@amd.com> Date: Wed, 25 Mar 2015 10:09:42 -0500 From: Suravee Suthikulpanit User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: "Rafael J. Wysocki" , Mika Westerberg CC: , , , , , , , , , , , , , , , Subject: Re: [V5 PATCH 1/2] ACPI / scan: Add support for ACPI _CLS device matching References: <1425622302-15193-1-git-send-email-Suravee.Suthikulpanit@amd.com> <55117373.3020808@amd.com> <20150324144346.GO1878@lahna.fi.intel.com> <1602323.I0oL7Cv9OO@vostro.rjw.lan> In-Reply-To: <1602323.I0oL7Cv9OO@vostro.rjw.lan> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-EOPAttributedMessage: 0 Authentication-Results: spf=none (sender IP is 165.204.84.222) smtp.mailfrom=Suravee.Suthikulpanit@amd.com; arndb.de; dkim=none (message not signed) header.d=none; X-Forefront-Antispam-Report: CIP:165.204.84.222;CTRY:US;IPV:NLI;EFV:NLI;BMV:1;SFV:NSPM;SFS:(10019020)(6009001)(428002)(24454002)(479174004)(164054003)(199003)(377454003)(189002)(51704005)(77096005)(2950100001)(87936001)(65956001)(62966003)(77156002)(93886004)(92566002)(101416001)(65816999)(47776003)(36756003)(80316001)(59896002)(76176999)(54356999)(87266999)(50986999)(83506001)(33656002)(23746002)(86362001)(46102003)(105586002)(106466001)(50466002)(87944003);DIR:OUT;SFP:1102;SCL:1;SRVR:BY2PR02MB058;H:atltwp02.amd.com;FPR:;SPF:None;MLV:sfv;A:1;MX:1;LANG:en; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR02MB058;UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR02MB284; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5002010)(5005006);SRVR:BY2PR02MB058;BCL:0;PCL:0;RULEID:;SRVR:BY2PR02MB058; X-Forefront-PRVS: 052670E5A4 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2015 15:10:00.8982 (UTC) X-MS-Exchange-CrossTenant-Id: fde4dada-be84-483f-92cc-e026cbee8e96 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fde4dada-be84-483f-92cc-e026cbee8e96;Ip=[165.204.84.222];Helo=[atltwp02.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR02MB058 X-OriginatorOrg: amd4.onmicrosoft.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/24/15 15:20, Rafael J. Wysocki wrote: > On Tuesday, March 24, 2015 04:43:46 PM Mika Westerberg wrote: >> On Tue, Mar 24, 2015 at 09:23:47AM -0500, Suravee Suthikulpanit wrote: >>> On 3/9/15 10:20, Mika Westerberg wrote: >>>>> [....] >>>>> diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_devicetable.h >>>>> index e530533..9a42522 100644 >>>>> --- a/include/linux/mod_devicetable.h >>>>> +++ b/include/linux/mod_devicetable.h >>>>> @@ -189,6 +189,7 @@ struct css_device_id { >>>>> struct acpi_device_id { >>>>> __u8 id[ACPI_ID_LEN]; >>>>> kernel_ulong_t driver_data; >>>>> + __u32 cls; >>>> >>>> It would be nice if we could change ordering here but I understand that >>>> it breaks quite many drivers. Perhaps we should consider creating >>>> ACPI_DEVICE() macro and convert existing drivers to that at some point. >>> >>> Yes, a roughly grep in the drivers directory showing about 112 files at the >>> moment. If you think this is the right approach going forward, we can work >>> on cleaning this up on a separate patch series. Please let me know what you >>> think. >> >> I think having ACPI_DEVICE() macro would be pretty useful and it avoids >> things like this if we need to add new fields in the future. Rafael has >> the last word, though :-) > > I agree. Okay, how should I organize this big change? Can we do this as a separate patch series? Thanks, Suravee