LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Prarit Bhargava <prarit@redhat.com>
To: John Stultz <john.stultz@linaro.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
	Shuah Khan <shuahkh@osg.samsung.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Richard Cochran <richardcochran@gmail.com>
Subject: Re: [PATCH 1/2] kselftests: timers: Make set-timer-lat fail more gracefully for !CAP_WAKE_ALARM
Date: Thu, 26 Mar 2015 07:31:15 -0400	[thread overview]
Message-ID: <5513EE03.1020507@redhat.com> (raw)
In-Reply-To: <1427327073-19011-1-git-send-email-john.stultz@linaro.org>



On 03/25/2015 07:44 PM, John Stultz wrote:
> The set-timer-lat test fails when testing CLOCK_BOOTTIME_ALARM
> or CLOCK_REALTIME_ALARM when the user isn't running as root or
> with CAP_WAKE_ALARM.
> 
> So this patch improves the error checking so we report the
> issue more clearly and continue rather then reporting a failure.
> 
> Cc: Shuah Khan <shuahkh@osg.samsung.com>
> Cc: Prarit Bhargava <prarit@redhat.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Richard Cochran <richardcochran@gmail.com>
> Signed-off-by: John Stultz <john.stultz@linaro.org>
> Signed-off-by: John Stultz <john.stultz@linaro.org>
> ---
>  tools/testing/selftests/timers/set-timer-lat.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/tools/testing/selftests/timers/set-timer-lat.c b/tools/testing/selftests/timers/set-timer-lat.c
> index 3ea2eff..dbc9537c 100644
> --- a/tools/testing/selftests/timers/set-timer-lat.c
> +++ b/tools/testing/selftests/timers/set-timer-lat.c
> @@ -139,6 +139,13 @@ int do_timer(int clock_id, int flags)
>  
>  	err = timer_create(clock_id, &se, &tm1);
>  	if (err) {
> +		if ((clock_id == CLOCK_REALTIME_ALARM)
> +				|| (clock_id == CLOCK_BOOTTIME_ALARM)) {

I dunno of there is actually a CodingStyle rule for this, but I've always seen
this written with the operator on the first line:

	if ((clock_id == CLOCK_REALTIME_ALARM) ||
            (clock_id == CLOCK_BOOTTIME_ALARM)) {

> +			printf("%-22s %s missing CAP_WAKE_ALARM?    : [UNSUPPORTED]\n",
> +					clockstring(clock_id),
> +					flags ? "ABSTIME":"RELTIME");

Something to think about:  Do you want to write these tests to be more human
readable or machine readable?  In theory with awk I guess it doesn't matter too
much, however, it is something that we should think about moving forward.

P.

  parent reply	other threads:[~2015-03-26 11:31 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-25 23:44 John Stultz
2015-03-25 23:44 ` [PATCH 2/2] kselftests: timers: Reduce default runtime on inconsistency-check and set-timer-lat John Stultz
2015-03-26 11:32   ` Prarit Bhargava
2015-03-26 16:20     ` John Stultz
2015-03-31 16:01       ` Shuah Khan
2015-03-31 19:47         ` Shuah Khan
2015-03-26 11:31 ` Prarit Bhargava [this message]
2015-03-26 16:29   ` [PATCH 1/2] kselftests: timers: Make set-timer-lat fail more gracefully for !CAP_WAKE_ALARM John Stultz
2015-03-26 17:33     ` Tyler Baker
2015-04-02 10:18       ` Prarit Bhargava
2015-04-02 13:43         ` Shuah Khan
2015-04-02 17:17           ` Tyler Baker
2015-04-02 17:48             ` Shuah Khan
2015-04-02 18:58               ` Tyler Baker
2015-04-02 18:02         ` John Stultz
2015-04-07 14:20           ` Prarit Bhargava
2015-04-08  4:03           ` Michael Ellerman
2015-04-02 10:14     ` Prarit Bhargava
2015-03-31 15:55   ` Shuah Khan
2015-04-02  3:42     ` John Stultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5513EE03.1020507@redhat.com \
    --to=prarit@redhat.com \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=richardcochran@gmail.com \
    --cc=shuahkh@osg.samsung.com \
    --cc=tglx@linutronix.de \
    --subject='Re: [PATCH 1/2] kselftests: timers: Make set-timer-lat fail more gracefully for '\!'CAP_WAKE_ALARM' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).