From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754111AbbCaAcd (ORCPT ); Mon, 30 Mar 2015 20:32:33 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:39265 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753419AbbCaAcb (ORCPT ); Mon, 30 Mar 2015 20:32:31 -0400 Message-ID: <5519EB1D.6070200@codeaurora.org> Date: Mon, 30 Mar 2015 17:32:29 -0700 From: Stephen Boyd User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Andy Shevchenko , linux-kernel@vger.kernel.org, heikki.krogerus@linux.intel.com Subject: Re: [PATCH v2 1/2] clk: fractional-divider: switch to rational best approximation References: <1427741869-239562-1-git-send-email-andriy.shevchenko@linux.intel.com> <1427741869-239562-2-git-send-email-andriy.shevchenko@linux.intel.com> In-Reply-To: <1427741869-239562-2-git-send-email-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/30/15 11:57, Andy Shevchenko wrote: > This patch converts the code to use rational best approximation algorithm which > is more precise. > > Suggested-by: Stephen Boyd > Signed-off-by: Andy Shevchenko > --- > drivers/clk/Kconfig | 3 +-- > drivers/clk/clk-fractional-divider.c | 39 ++++++++++++++---------------------- > 2 files changed, 16 insertions(+), 26 deletions(-) > > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > index 0b474a0..46d90a9 100644 > --- a/drivers/clk/Kconfig > +++ b/drivers/clk/Kconfig > @@ -14,6 +14,7 @@ config COMMON_CLK > select HAVE_CLK_PREPARE > select CLKDEV_LOOKUP > select SRCU > + select RATIONAL > ---help--- > The common clock framework is a single definition of struct > clk, useful across many platforms, as well as an > @@ -63,7 +64,6 @@ config COMMON_CLK_SI5351 > tristate "Clock driver for SiLabs 5351A/B/C" > depends on I2C > select REGMAP_I2C > - select RATIONAL > ---help--- > This driver supports Silicon Labs 5351A/B/C programmable clock > generators. > @@ -139,7 +139,6 @@ config COMMON_CLK_CDCE706 > tristate "Clock driver for TI CDCE706 clock synthesizer" > depends on I2C > select REGMAP_I2C > - select RATIONAL > ---help--- > This driver supports TI CDCE706 programmable 3-PLL clock synthesizer. Will some kernel janitor find us if we leave the selects here? I know you removed it because COMMON_CLK must be Y here and we'd always select RATIONAL, but it feels better to leave it alone and actually split off the basic clock types into individual configs so that the tiny kernel users don't have unused code lying around. That could be future work someday and then we might forget to select RATIONAL again. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project