LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Henrik Rydberg <rydberg@bitmath.org>,
	Peter Hutterer <peter.hutterer@redhat.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] Balanced slots, attempt #2
Date: Tue, 31 Mar 2015 09:11:07 +0200	[thread overview]
Message-ID: <551A488B.3060206@redhat.com> (raw)
In-Reply-To: <1427753368-2795-1-git-send-email-benjamin.tissoires@redhat.com>

Hi,

On 31-03-15 00:09, Benjamin Tissoires wrote:
> Hi,
>
> So, it occurs that the balanced slots assignment introduced in v4.0 had some
> troubles and the Synaptics part was reverted.
> I tried to spend some time today to figure out a solution, and the only way
> I can get something from it is to add a band aid in input_mt_set_slots().
>
> It should not be very costly, but I think it is required: I can guarantee that
> the path is hit if the band aid is not here (pr_err was my friend).
>
> So the series is:
> - band aid
> - revert the revert
> - small fix in synaptics.c to keep the slots stable when landing a third finger.
>
> Cheers,
> Benjamin

The entire set looks good to me:

Acked-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans

      parent reply	other threads:[~2015-03-31  7:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-30 22:09 Benjamin Tissoires
2015-03-30 22:09 ` [PATCH 1/3] Input: mt - prevent balanced slot assignment to assign twice the slot Benjamin Tissoires
2015-03-31  7:24   ` Henrik Rydberg
2015-03-31 14:58     ` Benjamin Tissoires
2015-03-30 22:09 ` [PATCH 2/3] Revert "Revert "Input: synaptics - use dmax in input_mt_assign_slots"" Benjamin Tissoires
2015-03-30 22:09 ` [PATCH 3/3] Input: synaptics - allocate 3 slots to keep stability in image sensors Benjamin Tissoires
2015-03-31  7:11 ` Hans de Goede [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=551A488B.3060206@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter.hutterer@redhat.com \
    --cc=rydberg@bitmath.org \
    --subject='Re: [PATCH 0/3] Balanced slots, attempt #2' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).