LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] dmaengine: pl330: fix the race condition in pl330 driver.
@ 2015-03-26 23:55 Scott Branden
  2015-03-29 21:55 ` Scott Branden
  2015-03-30 16:47 ` Jassi Brar
  0 siblings, 2 replies; 7+ messages in thread
From: Scott Branden @ 2015-03-26 23:55 UTC (permalink / raw)
  To: Dan Williams, Vinod Koul
  Cc: bcm-kernel-feedback-list, Dmitry Torokhov, Anatol Pomazao,
	linux-kernel, linux-arm-kernel, ismail, Scott Branden

From: ismail <ismail@broadcom.com>

Update the thread running index before issuing the
GO command to the DMAC.

Tested-by: Mohamed Ismail Abdul Packir Mohamed <ismail@broadcom.com>
Reviewed-by: Ray Jui <rjui@broadcom.com>
Reviewed-by: Arun Parameswaran <aparames@broadcom.com>
Reviewed-by: Scott Branden <sbranden@broadcom.com>
Signed-off-by: Scott Branden <sbranden@broadcom.com>
Signed-off-by: Mohamed Ismail Abdul Packir Mohamed <ismail@broadcom.com>
---
 drivers/dma/pl330.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
index 0e1f567..631642d 100644
--- a/drivers/dma/pl330.c
+++ b/drivers/dma/pl330.c
@@ -1072,11 +1072,11 @@ static bool _trigger(struct pl330_thread *thrd)
 	/* Set to generate interrupts for SEV */
 	writel(readl(regs + INTEN) | (1 << thrd->ev), regs + INTEN);
 
+	thrd->req_running = idx;
+
 	/* Only manager can execute GO */
 	_execute_DBGINSN(thrd, insn, true);
 
-	thrd->req_running = idx;
-
 	return true;
 }
 
-- 
2.3.3


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2015-03-31 22:04 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-26 23:55 [PATCH] dmaengine: pl330: fix the race condition in pl330 driver Scott Branden
2015-03-29 21:55 ` Scott Branden
2015-03-30 16:47 ` Jassi Brar
2015-03-30 17:25   ` Vinod Koul
2015-03-31  3:40     ` Scott Branden
2015-03-31  5:20       ` Jassi Brar
2015-03-31 22:04         ` Scott Branden

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).