LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Georgi Djakov <georgi.djakov@linaro.org>
To: Hai Li <hali@codeaurora.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] clk: qcom: Introduce parent_map tables
Date: Wed, 01 Apr 2015 22:46:36 +0300	[thread overview]
Message-ID: <551C4B1C.6060804@linaro.org> (raw)
In-Reply-To: <loom.20150401T161124-231@post.gmane.org>

On 1.04.15 17:22, Hai Li wrote:
> Hi Djakov,
> 
> Georgi Djakov <georgi.djakov <at> linaro.org> writes:
> 
>>
>> In the current parent mapping code, we can get duplicate or 
> inconsistent
>> indexes, which leads to discrepancy between the number of elements in 
> the
>> array and the number of parents. Until now, this was solved with some
>> reordering but this is not always possible.
>>
>> This patch introduces index tables that are used to define the 
> relations
>> between the PLL source and the hardware mux configuration value.
>> To accomplish this, here we do the following:
> 
> 
> There are other functions using f->src as index directly to find the 
> parent clock, at least the followings in file clk-rcg2.c:
> clk_pixel_determine_rate()
> _freq_tbl_determine_rate()
> clk_pixel_set_rate()
> clk_edp_pixel_determine_rate()
> clk_byte_determine_rate()
> 
> Shall we convert the index using qcom_find_src_index() at all these 
> places?
> 

Hi,
Yes, thanks for reporting this. I am working on a fix and trying
to verify it on all the platforms.

BR,
Georgi

  reply	other threads:[~2015-04-01 19:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-20 16:30 [PATCH v3 0/3] " Georgi Djakov
2015-03-20 16:30 ` [PATCH v3 1/3] clk: qcom: Fix clk_get_parent function return value Georgi Djakov
2015-03-20 16:30 ` [PATCH v3 2/3] clk: qcom: Do some error handling in configure_bank() Georgi Djakov
2015-03-20 16:30 ` [PATCH v3 3/3] clk: qcom: Introduce parent_map tables Georgi Djakov
2015-04-01 14:22   ` Hai Li
2015-04-01 19:46     ` Georgi Djakov [this message]
2015-03-23 23:24 ` [PATCH v3 0/3] " Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=551C4B1C.6060804@linaro.org \
    --to=georgi.djakov@linaro.org \
    --cc=hali@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH v3 3/3] clk: qcom: Introduce parent_map tables' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).