LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: "Chentao (Boby)" <boby.chen@huawei.com>, <konrad.wilk@oracle.com>,
	<joe@perches.com>
Cc: <xen-devel@lists.xenproject.org>, <linux-kernel@vger.kernel.org>,
	<wu.wubin@huawei.com>, <rudy.zhangmin@huawei.com>
Subject: Re: [PATCH v2] xen-blkback: define pr_fmt macro to avoid the duplication of DRV_PFX
Date: Thu, 2 Apr 2015 13:45:45 +0200	[thread overview]
Message-ID: <551D2BE9.2000002@citrix.com> (raw)
In-Reply-To: <551C9C42.6020604@huawei.com>

El 02/04/15 a les 3.32, Chentao (Boby) ha escrit:
> 
> 
> On 2015/4/1 23:04, Tao Chen wrote:
>> Define pr_fmt macro with {xen-blkback: } prefix, then remove all use
>> of DRV_PFX in the pr sentences. Replace all DPRINTK with pr sentences,
>> and get rid of DPRINTK macro. It will simplify the code.
>>
>> And if the pr sentences miss a \n, add it in the end. If the DPRINTK
>> sentences have redundant \n, remove it. It will format the code.
>>
> 
> I'm sorry, I made a mistake in this patch log. It must be changed as below.
> 
> And if the pr sentences miss a \n, add it in the end. It will format the
> code.
> 
> I apologize for the disturb of wrong patch log. Very looking forward
> to your reply.
> 
>> These all make the readability of the code become better.
>>
>> Signed-off-by: Tao Chen <boby.chen@huawei.com>

Thanks, with the commit message amended:

Acked-by: Roger Pau Monné <roger.pau@citrix.com>


      reply	other threads:[~2015-04-02 11:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-01 15:04 Tao Chen
2015-04-02  1:32 ` Chentao (Boby)
2015-04-02 11:45   ` Roger Pau Monné [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=551D2BE9.2000002@citrix.com \
    --to=roger.pau@citrix.com \
    --cc=boby.chen@huawei.com \
    --cc=joe@perches.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rudy.zhangmin@huawei.com \
    --cc=wu.wubin@huawei.com \
    --cc=xen-devel@lists.xenproject.org \
    --subject='Re: [PATCH v2] xen-blkback: define pr_fmt macro to avoid the duplication of DRV_PFX' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).