Re: [RFC PATCH 1/2] dt-bindings: PCI: Add Apple PCI controller

[Mark Kettenis <mark.kettenis@xs4all.nl>]

> Date: Sun, 15 Aug 2021 21:34:36 -0400
> From: Alyssa Rosenzweig <alyssa@rosenzweig.io>
> 
> Hi Marc,
> 
> > > Document the properties used by the Apple PCI controller. This is a
> > > fairly standard PCI controller, although it is not derived from any
> > > known non-Apple IP.
> > > 
> > > Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
> > 
> > I would rather you post something as an extension to Mark's work, for
> > multiple reasons:
> > 
> > - Mark's patch is still being discussed, and is the current
> >   reference (specially given that it is already in use in OpenBSD and
> >   u-boot).
> >   
> > - we cannot have multiple bindings. There can only be one, shared
> >   across implementations. Otherwise, you need a different kernel
> >   depending on whether you are booting from m1n1 or u-boot.
> > 
> > - what you have here is vastly inconsistent (you are describing the
> >   MSIs twice, using two different methods).
> 
> Absolutely agree, the frankenstein bindings here were the main reason v1
> was marked RFC. For v2, I've rebased on Mark's patch, which makes a
> bunch of driver magic disappear.

I updated the t8103.dtsi bindings on the apple-m1-m1n1-nvme branch in
my u-boot repository to be more in line with the current DT binding
proposal.

Note that the format of the msi-ranges property is still under
discussion.  See:

http://patchwork.ozlabs.org/project/devicetree-bindings/patch/20210726083204.93196-2-mark.kettenis@xs4all.nl/

Cheers,

Mark