LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Joel Fernandes <joelaf@google.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	"Joel Fernandes (Google)" <joel@joelfernandes.org>,
	rostedt <rostedt@goodmis.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Tom Zanussi <tom.zanussi@linux.intel.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Boqun Feng <boqun.feng@gmail.com>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	fweisbec <fweisbec@gmail.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	kbuild test robot <fengguang.wu@intel.com>,
	baohong liu <baohong.liu@intel.com>,
	vedang patel <vedang.patel@intel.com>,
	kernel-team <kernel-team@android.com>
Subject: Re: [PATCH RFC v6 4/5] tracepoint: Make rcuidle tracepoint callers use SRCU
Date: Mon, 7 May 2018 17:05:41 -0400 (EDT)	[thread overview]
Message-ID: <568999860.209.1525727141943.JavaMail.zimbra@efficios.com> (raw)
In-Reply-To: <20180507204143.13061-5-joelaf@google.com>

----- On May 7, 2018, at 4:41 PM, Joel Fernandes joelaf@google.com wrote:
[...]
> +extern struct srcu_struct tracepoint_srcu;
> +
> extern int
> tracepoint_probe_register(struct tracepoint *tp, void *probe, void *data);
> extern int
> @@ -77,6 +80,9 @@ int unregister_tracepoint_module_notifier(struct
> notifier_block *nb)
>  */
> static inline void tracepoint_synchronize_unregister(void)
> {
> +#ifdef CONFIG_TRACEPOINTS
> +	synchronize_srcu(&tracepoint_srcu);
> +#endif
> 	synchronize_sched();

Why is this ifdef needed ?

Thanks,

Mathieu

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com

  reply	other threads:[~2018-05-07 21:05 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-07 20:41 [PATCH RFC v6 0/5] Centralize and unify usage of preempt/irq tracepoints Joel Fernandes
2018-05-07 20:41 ` [PATCH RFC v6 1/5] srcu: Add notrace variants of srcu_read_{lock,unlock} Joel Fernandes
2018-05-07 20:41 ` [PATCH RFC v6 2/5] srcu: Add notrace variant of srcu_dereference Joel Fernandes
2018-05-07 20:41 ` [PATCH RFC v6 3/5] trace/irqsoff: Split reset into separate functions Joel Fernandes
2018-05-07 20:41 ` [PATCH RFC v6 4/5] tracepoint: Make rcuidle tracepoint callers use SRCU Joel Fernandes
2018-05-07 21:05   ` Mathieu Desnoyers [this message]
2018-05-07 21:46     ` Joel Fernandes
2018-05-08  0:37       ` Mathieu Desnoyers
2018-05-08 21:10         ` Joel Fernandes
2018-05-07 21:08   ` Paul E. McKenney
2018-05-07 21:17     ` Mathieu Desnoyers
2018-05-07 21:45     ` Joel Fernandes
2018-05-07 21:55       ` Paul E. McKenney
2018-05-07 23:37         ` Joel Fernandes
2018-05-07 20:41 ` [PATCH RFC v6 5/5] tracing: Centralize preemptirq tracepoints and unify their usage Joel Fernandes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=568999860.209.1525727141943.JavaMail.zimbra@efficios.com \
    --to=mathieu.desnoyers@efficios.com \
    --cc=baohong.liu@intel.com \
    --cc=boqun.feng@gmail.com \
    --cc=fengguang.wu@intel.com \
    --cc=fweisbec@gmail.com \
    --cc=joel@joelfernandes.org \
    --cc=joelaf@google.com \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=rdunlap@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=tom.zanussi@linux.intel.com \
    --cc=vedang.patel@intel.com \
    --subject='Re: [PATCH RFC v6 4/5] tracepoint: Make rcuidle tracepoint callers use SRCU' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).