LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] ide section fixes
@ 2007-02-01 13:52 Al Viro
  2007-02-06 22:48 ` Bartlomiej Zolnierkiewicz
  0 siblings, 1 reply; 3+ messages in thread
From: Al Viro @ 2007-02-01 13:52 UTC (permalink / raw)
  To: torvalds; +Cc: bzolnier, linux-kernel


a) cleanup_module() should be __exit
b) externs should match reality

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
 drivers/ide/ide.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/ide/ide.c b/drivers/ide/ide.c
index 3b334af..6c9bd51 100644
--- a/drivers/ide/ide.c
+++ b/drivers/ide/ide.c
@@ -1781,9 +1781,9 @@ done:
 	return 1;
 }
 
-extern void pnpide_init(void);
-extern void pnpide_exit(void);
-extern void h8300_ide_init(void);
+extern void __init pnpide_init(void);
+extern void __exit pnpide_exit(void);
+extern void __init h8300_ide_init(void);
 
 /*
  * probe_for_hwifs() finds/initializes "known" IDE interfaces
@@ -2088,7 +2088,7 @@ int __init init_module (void)
 	return ide_init();
 }
 
-void cleanup_module (void)
+void __exit cleanup_module (void)
 {
 	int index;
 
-- 
1.5.0-rc2.GIT



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ide section fixes
  2007-02-01 13:52 [PATCH] ide section fixes Al Viro
@ 2007-02-06 22:48 ` Bartlomiej Zolnierkiewicz
  2007-02-07  1:06   ` Bartlomiej Zolnierkiewicz
  0 siblings, 1 reply; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2007-02-06 22:48 UTC (permalink / raw)
  To: Al Viro; +Cc: torvalds, linux-kernel

On 2/1/07, Al Viro <viro@ftp.linux.org.uk> wrote:
>
> a) cleanup_module() should be __exit
> b) externs should match reality
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

applied, thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ide section fixes
  2007-02-06 22:48 ` Bartlomiej Zolnierkiewicz
@ 2007-02-07  1:06   ` Bartlomiej Zolnierkiewicz
  0 siblings, 0 replies; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2007-02-07  1:06 UTC (permalink / raw)
  To: Al Viro; +Cc: torvalds, linux-kernel

On 2/6/07, Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote:
> On 2/1/07, Al Viro <viro@ftp.linux.org.uk> wrote:
> >
> > a) cleanup_module() should be __exit
> > b) externs should match reality
> >
> > Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
>
> applied, thanks

hmm, Linus has already applied, great :)

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-02-07  1:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-01 13:52 [PATCH] ide section fixes Al Viro
2007-02-06 22:48 ` Bartlomiej Zolnierkiewicz
2007-02-07  1:06   ` Bartlomiej Zolnierkiewicz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).