LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Harvey Harrison" <harvey.harrison@gmail.com>
To: "Andrew Morton" <akpm@linux-foundation.org>
Cc: linux-arch <linux-arch@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] kprobes: Introduce kprobe_handle_fault()
Date: Fri, 29 Feb 2008 08:30:43 -0800	[thread overview]
Message-ID: <590657100802290830y1e4786adi1411e8a4e4b277f4@mail.gmail.com> (raw)
In-Reply-To: <20080229031656.1abac83a.akpm@linux-foundation.org>

On Fri, Feb 29, 2008 at 3:16 AM, Andrew Morton
<akpm@linux-foundation.org> wrote:
> On Sat, 02 Feb 2008 19:00:23 -0800 Harvey Harrison <harvey.harrison@gmail.com> wrote:
>
>  > Use a central kprobe_handle_fault() inline in kprobes.h to remove
>  > all of the arch-dependant, practically identical implementations in
>  > avr32, ia64, powerpc, s390, sparc64, and x86.
>  >
>  > avr32 was the only arch without the preempt_disable/enable pair
>  > in its notify_page_fault implementation.
>  >
>  > This uncovered a possible bug in the s390 version as that purely
>  > copied the x86 version unconditionally passing 14 as the trapnr
>  > rather than the error_code parameter.  s390 is changed to pass
>  > error_code in this patch.
>  >
>  > Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
>  > ---
>  > Andrew, 1/2 is low risk, 2/2 has been tested on x86-32 and 64,
>  > but the !preemptible invariant seems correct.
>  >
>  >  arch/arm/mm/fault.c     |   25 +------------------------
>  >  arch/avr32/mm/fault.c   |   21 +--------------------
>  >  arch/ia64/mm/fault.c    |   24 +-----------------------
>  >  arch/powerpc/mm/fault.c |   25 +------------------------
>  >  arch/s390/mm/fault.c    |   25 +------------------------
>  >  arch/sparc64/mm/fault.c |   23 +----------------------
>  >  arch/x86/mm/fault.c     |   26 ++------------------------
>  >  include/linux/kprobes.h |   20 ++++++++++++++++++++
>  >  8 files changed, 28 insertions(+), 161 deletions(-)
>
>  Breaks the ia64 build:
>
>  include/linux/kprobes.h: In function `kprobe_handle_fault':
>  include/linux/kprobes.h:234: error: implicit declaration of function `kprobe_fault_handler'
>
>  and ia64 doesn't implement kprobe_fault_handler() so there's no easy fix
>  here.

Yes there is, ia64 apparently called theirs kprobes_handle_fault, sorry I didn't
notice the extra 's'.  Want a new patch, or will you change the three
occurances?

Harvey

  reply	other threads:[~2008-02-29 16:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-03  3:00 Harvey Harrison
2008-02-03 11:52 ` Heiko Carstens
2008-02-07 19:12 ` Masami Hiramatsu
2008-02-29 11:16 ` Andrew Morton
2008-02-29 16:30   ` Harvey Harrison [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-01-07 20:24 [PATCHv2] kprobes: Introduce is_kprobe_fault() Harvey Harrison
2008-01-08 22:45 ` Paul Mackerras
2008-01-08 23:02   ` Harvey Harrison
2008-01-09  4:19     ` [PATCHv3] kprobes: Introduce kprobe_handle_fault() Harvey Harrison
2008-01-09  6:14       ` Heiko Carstens
2008-01-09  6:22         ` Harvey Harrison
2008-01-09 22:01           ` [PATCHv4] " Harvey Harrison
2008-01-09 23:16             ` Heiko Carstens
2008-01-10  0:44               ` [PATCH 1/2] " Harvey Harrison
2008-01-10  3:15                 ` Masami Hiramatsu
2008-01-10 12:50                 ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=590657100802290830y1e4786adi1411e8a4e4b277f4@mail.gmail.com \
    --to=harvey.harrison@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH 1/2] kprobes: Introduce kprobe_handle_fault()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).