LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: "Wei Hu (Xavier)" <xavier.huwei@huawei.com> To: Leon Romanovsky <leon@kernel.org> Cc: <dledford@redhat.com>, <jgg@ziepe.ca>, <linux-rdma@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <xavier.huwei@tom.com>, <lijun_nudt@163.com> Subject: Re: [PATCH rdma-next 3/5] RDMA/hns: Increase checking CMQ status timeout value Date: Wed, 23 May 2018 14:15:48 +0800 [thread overview] Message-ID: <5B050714.2040205@huawei.com> (raw) In-Reply-To: <5B0505A9.8040908@huawei.com> On 2018/5/23 14:09, Wei Hu (Xavier) wrote: > > On 2018/5/23 13:49, Leon Romanovsky wrote: >> On Thu, May 17, 2018 at 04:02:51PM +0800, Wei Hu (Xavier) wrote: >>> This patch increases checking CMQ status timeout value and >>> uses the same value with NIC driver to avoid deficiency of >>> time. >>> >>> Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com> >>> --- >>> drivers/infiniband/hw/hns/hns_roce_hw_v2.h | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.h b/drivers/infiniband/hw/hns/hns_roce_hw_v2.h >>> index 182b672..f16df1b 100644 >>> --- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.h >>> +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.h >>> @@ -76,7 +76,7 @@ >>> #define HNS_ROCE_V2_PAGE_SIZE_SUPPORTED 0xFFFFF000 >>> #define HNS_ROCE_V2_MAX_INNER_MTPT_NUM 2 >>> #define HNS_ROCE_INVALID_LKEY 0x100 >>> -#define HNS_ROCE_CMQ_TX_TIMEOUT 200 >>> +#define HNS_ROCE_CMQ_TX_TIMEOUT 30000 >> Don't you think that loop of 30 seconds too much? >> >> Thanks > Leon, 30ms Because firmware take turns excuting NIC and RoCE command. Although RoCE command does not take so long, we still use the same timeout value with NIC driver. Thanks >>> #define HNS_ROCE_CONTEXT_HOP_NUM 1 >>> #define HNS_ROCE_MTT_HOP_NUM 1 >>> -- >>> 1.9.1 >>> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > . >
next prev parent reply other threads:[~2018-05-23 6:15 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-17 8:02 [PATCH rdma-next 0/5] Misc update for hns driver Wei Hu (Xavier) 2018-05-17 8:02 ` [PATCH rdma-next 1/5] RDMA/hns: Implement the disassociate_ucontext API Wei Hu (Xavier) 2018-05-17 15:00 ` Jason Gunthorpe 2018-05-19 8:24 ` Wei Hu (Xavier) 2018-05-22 20:21 ` Jason Gunthorpe 2018-05-23 9:33 ` Wei Hu (Xavier) 2018-05-17 8:02 ` [PATCH rdma-next 2/5] RDMA/hns: Modify uar allocation algorithm to avoid bitmap exhaust Wei Hu (Xavier) 2018-05-23 6:05 ` Leon Romanovsky 2018-05-23 6:49 ` Wei Hu (Xavier) 2018-05-23 7:00 ` Leon Romanovsky 2018-05-23 7:12 ` Wei Hu (Xavier) 2018-05-23 7:22 ` Leon Romanovsky 2018-05-17 8:02 ` [PATCH rdma-next 3/5] RDMA/hns: Increase checking CMQ status timeout value Wei Hu (Xavier) 2018-05-23 5:49 ` Leon Romanovsky 2018-05-23 6:09 ` Wei Hu (Xavier) 2018-05-23 6:15 ` Wei Hu (Xavier) [this message] 2018-05-23 6:23 ` Leon Romanovsky 2018-05-17 8:02 ` [PATCH rdma-next 4/5] RDMA/hns: Add reset process for RoCE in hip08 Wei Hu (Xavier) 2018-05-17 15:14 ` Jason Gunthorpe 2018-05-18 3:28 ` Wei Hu (Xavier) 2018-05-18 4:15 ` Jason Gunthorpe 2018-05-18 7:23 ` Wei Hu (Xavier) 2018-05-22 20:26 ` Jason Gunthorpe 2018-05-23 2:54 ` Wei Hu (Xavier) 2018-05-23 3:47 ` Jason Gunthorpe 2018-05-23 9:35 ` Wei Hu (Xavier) 2018-05-23 3:49 ` Wei Hu (Xavier) 2018-05-17 8:02 ` [PATCH rdma-next 5/5] RDMA/hns: Fix the illegal memory operation when cross page Wei Hu (Xavier) 2018-05-23 6:17 ` Leon Romanovsky 2018-05-23 6:38 ` Wei Hu (Xavier)
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5B050714.2040205@huawei.com \ --to=xavier.huwei@huawei.com \ --cc=dledford@redhat.com \ --cc=jgg@ziepe.ca \ --cc=leon@kernel.org \ --cc=lijun_nudt@163.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rdma@vger.kernel.org \ --cc=xavier.huwei@tom.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).