LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: "Wei Hu (Xavier)" <xavier.huwei@huawei.com> To: Leon Romanovsky <leon@kernel.org> Cc: <dledford@redhat.com>, <jgg@ziepe.ca>, <linux-rdma@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <xavier.huwei@tom.com>, <lijun_nudt@163.com> Subject: Re: [PATCH rdma-next 2/5] RDMA/hns: Modify uar allocation algorithm to avoid bitmap exhaust Date: Wed, 23 May 2018 15:12:45 +0800 [thread overview] Message-ID: <5B05146D.901@huawei.com> (raw) In-Reply-To: <20180523070055.GD5729@mtr-leonro.mtl.com> On 2018/5/23 15:00, Leon Romanovsky wrote: > On Wed, May 23, 2018 at 02:49:35PM +0800, Wei Hu (Xavier) wrote: >> >> On 2018/5/23 14:05, Leon Romanovsky wrote: >>> On Thu, May 17, 2018 at 04:02:50PM +0800, Wei Hu (Xavier) wrote: >>>> This patch modified uar allocation algorithm in hns_roce_uar_alloc >>>> function to avoid bitmap exhaust. >>>> >>>> Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com> >>>> --- >>>> drivers/infiniband/hw/hns/hns_roce_device.h | 1 + >>>> drivers/infiniband/hw/hns/hns_roce_pd.c | 10 ++++++---- >>>> 2 files changed, 7 insertions(+), 4 deletions(-) >>>> >>>> diff --git a/drivers/infiniband/hw/hns/hns_roce_device.h b/drivers/infiniband/hw/hns/hns_roce_device.h >>>> index 53c2f1b..412297d4 100644 >>>> --- a/drivers/infiniband/hw/hns/hns_roce_device.h >>>> +++ b/drivers/infiniband/hw/hns/hns_roce_device.h >>>> @@ -214,6 +214,7 @@ enum { >>>> struct hns_roce_uar { >>>> u64 pfn; >>>> unsigned long index; >>>> + unsigned long logic_idx; >>>> }; >>>> >>>> struct hns_roce_ucontext { >>>> diff --git a/drivers/infiniband/hw/hns/hns_roce_pd.c b/drivers/infiniband/hw/hns/hns_roce_pd.c >>>> index 4b41e04..b9f2c87 100644 >>>> --- a/drivers/infiniband/hw/hns/hns_roce_pd.c >>>> +++ b/drivers/infiniband/hw/hns/hns_roce_pd.c >>>> @@ -107,13 +107,15 @@ int hns_roce_uar_alloc(struct hns_roce_dev *hr_dev, struct hns_roce_uar *uar) >>>> int ret = 0; >>>> >>>> /* Using bitmap to manager UAR index */ >>>> - ret = hns_roce_bitmap_alloc(&hr_dev->uar_table.bitmap, &uar->index); >>>> + ret = hns_roce_bitmap_alloc(&hr_dev->uar_table.bitmap, &uar->logic_idx); >>>> if (ret == -1) >>>> return -ENOMEM; >>>> >>>> - if (uar->index > 0) >>>> - uar->index = (uar->index - 1) % >>>> + if (uar->logic_idx > 0 && hr_dev->caps.phy_num_uars > 1) >>>> + uar->index = (uar->logic_idx - 1) % >>>> (hr_dev->caps.phy_num_uars - 1) + 1; >>>> + else >>>> + uar->index = 0; >>>> >>> Sorry, but maybe I didn't understand this change fully, but logic_idx is >>> not initialized at all and one of two (needs to check your uar >>> allocation): the logic_idx is always zero -> index will be zero too, >>> or logic_idx is random variable -> index will be random too. >>> >>> What did you want to do? >>> >> Hi, Leon >> >> The prototype of hns_roce_bitmap_alloc as belows: >> int hns_roce_bitmap_alloc(struct hns_roce_bitmap *bitmap, >> unsigned long *obj); >> In this statement, we evaluate uar->logic_idx. >> ret = hns_roce_bitmap_alloc(&hr_dev->uar_table.bitmap, >> &uar->logic_idx); >> >> In hip06, hr_dev->caps.phy_num_uars equals 8, >> if (uar->logic_idx > 0) >> uar-> index = 0; >> else >> uar-> index =(uar->logic_idx - 1) % >> (hr_dev->caps.phy_num_uars - 1) + 1; >> In hip08, hr_dev->caps.phy_num_uars equals 1, uar-> index = 0; >> >> Regards > Where did you change/set logic_idx? In hns_roce_uar_alloc, ret = hns_roce_bitmap_alloc(&hr_dev->uar_table.bitmap, &uar->logic_idx); In hns_roce_uar_free, hns_roce_bitmap_free(&hr_dev->uar_table.bitmap, uar->logic_idx, BITMAP_NO_RR); Thanks > Thanks > > >> Wei Hu >>>> if (!dev_is_pci(hr_dev->dev)) { >>>> res = platform_get_resource(hr_dev->pdev, IORESOURCE_MEM, 0); >>>> @@ -132,7 +134,7 @@ int hns_roce_uar_alloc(struct hns_roce_dev *hr_dev, struct hns_roce_uar *uar) >>>> >>>> void hns_roce_uar_free(struct hns_roce_dev *hr_dev, struct hns_roce_uar *uar) >>>> { >>>> - hns_roce_bitmap_free(&hr_dev->uar_table.bitmap, uar->index, >>>> + hns_roce_bitmap_free(&hr_dev->uar_table.bitmap, uar->logic_idx, >>>> BITMAP_NO_RR); >>>> } >>>> >>>> -- >>>> 1.9.1 >>>> >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-05-23 7:12 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-17 8:02 [PATCH rdma-next 0/5] Misc update for hns driver Wei Hu (Xavier) 2018-05-17 8:02 ` [PATCH rdma-next 1/5] RDMA/hns: Implement the disassociate_ucontext API Wei Hu (Xavier) 2018-05-17 15:00 ` Jason Gunthorpe 2018-05-19 8:24 ` Wei Hu (Xavier) 2018-05-22 20:21 ` Jason Gunthorpe 2018-05-23 9:33 ` Wei Hu (Xavier) 2018-05-17 8:02 ` [PATCH rdma-next 2/5] RDMA/hns: Modify uar allocation algorithm to avoid bitmap exhaust Wei Hu (Xavier) 2018-05-23 6:05 ` Leon Romanovsky 2018-05-23 6:49 ` Wei Hu (Xavier) 2018-05-23 7:00 ` Leon Romanovsky 2018-05-23 7:12 ` Wei Hu (Xavier) [this message] 2018-05-23 7:22 ` Leon Romanovsky 2018-05-17 8:02 ` [PATCH rdma-next 3/5] RDMA/hns: Increase checking CMQ status timeout value Wei Hu (Xavier) 2018-05-23 5:49 ` Leon Romanovsky 2018-05-23 6:09 ` Wei Hu (Xavier) 2018-05-23 6:15 ` Wei Hu (Xavier) 2018-05-23 6:23 ` Leon Romanovsky 2018-05-17 8:02 ` [PATCH rdma-next 4/5] RDMA/hns: Add reset process for RoCE in hip08 Wei Hu (Xavier) 2018-05-17 15:14 ` Jason Gunthorpe 2018-05-18 3:28 ` Wei Hu (Xavier) 2018-05-18 4:15 ` Jason Gunthorpe 2018-05-18 7:23 ` Wei Hu (Xavier) 2018-05-22 20:26 ` Jason Gunthorpe 2018-05-23 2:54 ` Wei Hu (Xavier) 2018-05-23 3:47 ` Jason Gunthorpe 2018-05-23 9:35 ` Wei Hu (Xavier) 2018-05-23 3:49 ` Wei Hu (Xavier) 2018-05-17 8:02 ` [PATCH rdma-next 5/5] RDMA/hns: Fix the illegal memory operation when cross page Wei Hu (Xavier) 2018-05-23 6:17 ` Leon Romanovsky 2018-05-23 6:38 ` Wei Hu (Xavier)
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5B05146D.901@huawei.com \ --to=xavier.huwei@huawei.com \ --cc=dledford@redhat.com \ --cc=jgg@ziepe.ca \ --cc=leon@kernel.org \ --cc=lijun_nudt@163.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rdma@vger.kernel.org \ --cc=xavier.huwei@tom.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).