LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH -next v2 resend] drm/bochs: Fix missing pci_disable_device() on error in bochs_pci_probe()
@ 2021-07-15 13:28 Yang Yingliang
  2021-07-20  9:07 ` Thomas Zimmermann
  0 siblings, 1 reply; 2+ messages in thread
From: Yang Yingliang @ 2021-07-15 13:28 UTC (permalink / raw)
  To: linux-kernel, dri-devel, virtualization
  Cc: kraxel, airlied, daniel, tzimmermann

Replace pci_enable_device() with pcim_enable_device(),
pci_disable_device() will be called in release automatically.

v2:
  use pcim_enable_device()

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reported-by: Hulk Robot <hulkci@huawei.com>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/bochs/bochs_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bochs/bochs_drv.c b/drivers/gpu/drm/bochs/bochs_drv.c
index c828cadbabff..8065c9537237 100644
--- a/drivers/gpu/drm/bochs/bochs_drv.c
+++ b/drivers/gpu/drm/bochs/bochs_drv.c
@@ -118,7 +118,7 @@ static int bochs_pci_probe(struct pci_dev *pdev,
 	if (IS_ERR(dev))
 		return PTR_ERR(dev);
 
-	ret = pci_enable_device(pdev);
+	ret = pcim_enable_device(pdev);
 	if (ret)
 		goto err_free_dev;
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH -next v2 resend] drm/bochs: Fix missing pci_disable_device() on error in bochs_pci_probe()
  2021-07-15 13:28 [PATCH -next v2 resend] drm/bochs: Fix missing pci_disable_device() on error in bochs_pci_probe() Yang Yingliang
@ 2021-07-20  9:07 ` Thomas Zimmermann
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Zimmermann @ 2021-07-20  9:07 UTC (permalink / raw)
  To: Yang Yingliang, linux-kernel, dri-devel, virtualization
  Cc: kraxel, airlied, daniel


[-- Attachment #1.1: Type: text/plain, Size: 1297 bytes --]

Hi

Am 15.07.21 um 15:28 schrieb Yang Yingliang:
> Replace pci_enable_device() with pcim_enable_device(),
> pci_disable_device() will be called in release automatically.
> 
> v2:
>    use pcim_enable_device()
> 
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Acked-by: Thomas Zimmermann <tzimmermann@suse.de>

Thanks, I'll merge it into drm-misc-next as v3. I also had to update the 
path to the bochs driver meanwhile.

Best regards
Thomas

> ---
>   drivers/gpu/drm/bochs/bochs_drv.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/bochs/bochs_drv.c b/drivers/gpu/drm/bochs/bochs_drv.c
> index c828cadbabff..8065c9537237 100644
> --- a/drivers/gpu/drm/bochs/bochs_drv.c
> +++ b/drivers/gpu/drm/bochs/bochs_drv.c
> @@ -118,7 +118,7 @@ static int bochs_pci_probe(struct pci_dev *pdev,
>   	if (IS_ERR(dev))
>   		return PTR_ERR(dev);
>   
> -	ret = pci_enable_device(pdev);
> +	ret = pcim_enable_device(pdev);
>   	if (ret)
>   		goto err_free_dev;
>   
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-07-20  9:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-15 13:28 [PATCH -next v2 resend] drm/bochs: Fix missing pci_disable_device() on error in bochs_pci_probe() Yang Yingliang
2021-07-20  9:07 ` Thomas Zimmermann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).