LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: kernel test robot <yujie.liu@intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: Matti Vaittinen <mazziesaccount@gmail.com>,
	Cristian Marussi <cristian.marussi@arm.com>,
	<clang-built-linux@googlegroups.com>, <kbuild-all@lists.01.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [kbuild] drivers/regulator/bd718x7-regulator.c:531:8: warning: Excessive padding in 'struct bd718xx_regulator_data' (8 padding bytes, where 0 is optimal).
Date: Sat, 21 Aug 2021 12:38:35 +0800	[thread overview]
Message-ID: <5cf8d0df-0fb7-5b91-53b2-9ceadbc23a7b@intel.com> (raw)
In-Reply-To: <20210819152353.GN4177@sirena.org.uk>

Hi Mark,

On 8/19/2021 11:23 PM, Mark Brown wrote:
> On Thu, Aug 19, 2021 at 10:49:13PM +0800, kernel test robot wrote:
> 
>> Sorry for bothering, we'll ignore struct padding warnings next time.
> 
> I think the warnings are useful, it's just that they're not important
> for all structs.  If the struct was getting allocated a lot it could be
> pointing out an issue that makes a real difference.  I'm not sure it s
> realistic for automation to figure it out for itself so it's better to
> send them even if they get ignored a lot.
> 

It's not very practical for automation to figure out how many copies of 
a struct would be created and how much space would be saved in total by 
adjusting struct padding.

For similar warnings in the future, we'll make an effort to do manual 
check first, and send out reports that we think are worthy of notice.

Best Regards,
Yujie Liu

      reply	other threads:[~2021-08-21  4:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <202108172206.9cbgvI53-lkp@intel.com>
2021-08-19  3:24 ` kernel test robot
2021-08-19  5:34   ` Matti Vaittinen
2021-08-19 11:37     ` Mark Brown
2021-08-19 14:49     ` kernel test robot
2021-08-19 15:23       ` Mark Brown
2021-08-21  4:38         ` kernel test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5cf8d0df-0fb7-5b91-53b2-9ceadbc23a7b@intel.com \
    --to=yujie.liu@intel.com \
    --cc=broonie@kernel.org \
    --cc=clang-built-linux@googlegroups.com \
    --cc=cristian.marussi@arm.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mazziesaccount@gmail.com \
    --subject='Re: [kbuild] drivers/regulator/bd718x7-regulator.c:531:8: warning: Excessive padding in '\''struct bd718xx_regulator_data'\'' (8 padding bytes, where 0 is optimal).' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).