LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Veerabhadrarao Badiganti <vbadigan@codeaurora.org>
To: Adrian Hunter <adrian.hunter@intel.com>, ulf.hansson@linaro.org
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, dianders@google.com,
	mka@chromium.org, Ritesh Harjani <riteshh@codeaurora.org>,
	Asutosh Das <asutoshd@codeaurora.org>
Subject: Re: [PATCH] mmc: cqhci: Update cqhci memory ioresource name
Date: Wed, 4 Mar 2020 18:42:06 +0530	[thread overview]
Message-ID: <5d19b5a1-3a1a-9366-fde2-ea0c0ee85dd6@codeaurora.org> (raw)
In-Reply-To: <e1bd6b82-01d1-ce71-d170-a891a18b8141@intel.com>


On 3/4/2020 5:53 PM, Adrian Hunter wrote:
> On 4/03/20 2:00 pm, Veerabhadrarao Badiganti wrote:
>> Update cqhci memory ioresource name from cqhci_mem to cqhci since
>> suffix _mem is redundant.
> Which is OK only because sdhci-msm is the only caller of cqhci_pltfm_init(),
> right?  So no one else could be using "cqhci_mem"? Some more explanation is
> needed here.

Right, only qcom cqhci solution is making use of it.

I did a grep in dt and find no other vendor is using it.

Sure. Will update commit text.

>> Signed-off-by: Veerabhadrarao Badiganti <vbadigan@codeaurora.org>
>> ---
>> Corresponding binding change:
>> https://lore.kernel.org/linux-arm-msm/1582545470-11530-1-git-send-email-vbadigan@codeaurora.org/
>> ---
>>   drivers/mmc/host/cqhci.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/host/cqhci.c b/drivers/mmc/host/cqhci.c
>> index e2ea2c4..e24b8ff 100644
>> --- a/drivers/mmc/host/cqhci.c
>> +++ b/drivers/mmc/host/cqhci.c
>> @@ -1077,7 +1077,7 @@ struct cqhci_host *cqhci_pltfm_init(struct platform_device *pdev)
>>   
>>   	/* check and setup CMDQ interface */
>>   	cqhci_memres = platform_get_resource_byname(pdev, IORESOURCE_MEM,
>> -						   "cqhci_mem");
>> +						   "cqhci");
>>   	if (!cqhci_memres) {
>>   		dev_dbg(&pdev->dev, "CMDQ not supported\n");
>>   		return ERR_PTR(-EINVAL);
>>

  reply	other threads:[~2020-03-04 13:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-04 12:00 Veerabhadrarao Badiganti
2020-03-04 12:23 ` Adrian Hunter
2020-03-04 13:12   ` Veerabhadrarao Badiganti [this message]
2020-03-04 13:25 ` [PATCH V2] " Veerabhadrarao Badiganti
2020-03-04 14:02   ` Adrian Hunter
2020-03-04 16:00   ` Doug Anderson
2020-03-09 18:30   ` Bjorn Andersson
2020-03-11 15:34   ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5d19b5a1-3a1a-9366-fde2-ea0c0ee85dd6@codeaurora.org \
    --to=vbadigan@codeaurora.org \
    --cc=adrian.hunter@intel.com \
    --cc=asutoshd@codeaurora.org \
    --cc=dianders@google.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=mka@chromium.org \
    --cc=riteshh@codeaurora.org \
    --cc=ulf.hansson@linaro.org \
    --subject='Re: [PATCH] mmc: cqhci: Update cqhci memory ioresource name' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).