From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EDD7C433FF for ; Tue, 30 Jul 2019 22:49:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 305BF206A2 for ; Tue, 30 Jul 2019 22:49:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="IQLFc52G" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727567AbfG3Wty (ORCPT ); Tue, 30 Jul 2019 18:49:54 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:42100 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725935AbfG3Wty (ORCPT ); Tue, 30 Jul 2019 18:49:54 -0400 Received: by mail-pf1-f194.google.com with SMTP id q10so30579981pff.9 for ; Tue, 30 Jul 2019 15:49:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=message-id:mime-version:content-transfer-encoding:in-reply-to :references:cc:from:to:subject:user-agent:date; bh=AyOWNmy5vkhOMtvfizoy9NHcme6ShFmvYaDFxpjtVss=; b=IQLFc52G5Bgqu4WQpIBhhFuI1m7LZSJJb9zty89yaP9wlcq36yHYuQZ5L9sYPn1dWp z4xdP3V9oJsGcQVGAwweNWQAOaEbGKaGO534ybxIVqWsLJ4/tPJ8tCJ/T7HtsvYvppR3 JQ9MZFGtbiWVdzzXt1cIZsDeQu0Lih3YA/iXM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:mime-version :content-transfer-encoding:in-reply-to:references:cc:from:to:subject :user-agent:date; bh=AyOWNmy5vkhOMtvfizoy9NHcme6ShFmvYaDFxpjtVss=; b=g4ga4mqk+6a/wVkXmbGGaFjSe+LSy4ir+YTuiwPPX7aQ8f4dlDVkmdHLHN7sJyyPOA GpTRjGDKlF52gizIcjGVVoGAPQ9FpnSVneBTdn34mORtVs+zAk48HhikRYqYaiKAnQYq /hDZqzOuJnJPQ2Pkle//QtBYEJbIuHVDGWPBfosFzoygHXybRdIjP+NWqlFDYHkNM5bC BX5lh13UhmBqEIVHqqUjYt2p6wS1x8Bc8mVxdnzwwDRwglpNNH++gJFXb694rmMNluW4 tlZE8cLr7qCt5LZQJnzSYF59zvtTIIIo1FDj7zABV3AalSlm/FQKdLcSPPnFyoYjCMIJ jbeA== X-Gm-Message-State: APjAAAV9QRw/LA4fNh19z0BJPQVexsgWof3f/sKwAuCzI/Q4/Sr9gD5v MXGosRQu5nwAe7pp/axwR2FbmQ== X-Google-Smtp-Source: APXvYqwFI+sk4Hdh0m5JaRPKeXUTfbKPUmsueFqjjVnLS1FM3XovmDN7hCtjM6loKzraxQQoIn4abQ== X-Received: by 2002:a62:750c:: with SMTP id q12mr45455489pfc.59.1564526993807; Tue, 30 Jul 2019 15:49:53 -0700 (PDT) Received: from chromium.org ([2620:15c:202:1:fa53:7765:582b:82b9]) by smtp.gmail.com with ESMTPSA id 14sm64070973pfy.40.2019.07.30.15.49.52 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 30 Jul 2019 15:49:53 -0700 (PDT) Message-ID: <5d40c991.1c69fb81.7f6c2.028d@mx.google.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20190523190925.GU31438@minitux> References: <20190501043734.26706-1-bjorn.andersson@linaro.org> <20190501043734.26706-3-bjorn.andersson@linaro.org> <5ce6e0cd.1c69fb81.9a03e.0260@mx.google.com> <20190523190925.GU31438@minitux> Cc: Doug Anderson , Andy Gross , David Brown , Rob Herring , Mark Rutland , linux-arm-msm , devicetree@vger.kernel.org, LKML From: Stephen Boyd To: Bjorn Andersson Subject: Re: [PATCH v7 2/4] soc: qcom: Add AOSS QMP driver User-Agent: alot/0.8.1 Date: Tue, 30 Jul 2019 15:49:51 -0700 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Bjorn Andersson (2019-05-23 12:09:25) >=20 > I had to read through the clock code to conclude that this was indeed > the design, so I'm happy with your patch of ensuring that this is > followed. Perhaps add a statement in the kerneldoc for struct clk_hw as > well to state that init won't be accessed past the return of > clk_register. >=20 I noticed that I had a branch for this that didn't go away this rebase. I've thrown this on my todo list now. I added the comment to the code, but I'm afraid I can't just merge this patch to clk-next yet because various drivers access hw->init after calling clk_register() and friends. I'll have to go through and find the users by looking at git grep '->init' -- drivers/clk/ results. This is a pain.