LKML Archive on
help / color / mirror / Atom feed
From: Joe Perches <>
To: Greg Kroah-Hartman <>,
	daniel watson <>
Cc: Lars-Peter Clausen <>,
	Michael Hennerich <>,
	Jonathan Cameron <>,,,
Subject: Re: [PATCH] staging:iio:ade7854 surround complex defines in parentheses
Date: Tue, 17 Aug 2021 01:50:46 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Tue, 2021-08-17 at 08:12 +0200, Greg Kroah-Hartman wrote:
> On Mon, Aug 16, 2021 at 09:30:38PM -0700, daniel watson wrote:
> > 
> > If this is a false positive from checkpatch, I can submit it as an
> > example to the checkpatch maintainers.  Do you think I should?
> checkpatch is a perl script that does pattern matching, it is really
> hard for it to determine for things like this specific example, that it
> is not needed.
> Try finding other valid checkpatch cleanups if you wish to contribute in
> this way, there are loads of others under drivers/staging/ that should
> be easy to find.

These macros, and several other '#define ADE7854_<FOO> <value>' instances,
are apparently unused and could possibly be removed instead.

  reply	other threads:[~2021-08-17  8:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-15  2:31 daniel watson
2021-08-15  6:25 ` Greg Kroah-Hartman
2021-08-17  4:30   ` daniel watson
2021-08-17  6:12     ` Greg Kroah-Hartman
2021-08-17  8:50       ` Joe Perches [this message]
2021-08-17  8:24     ` Fabio M. De Francesco

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] staging:iio:ade7854 surround complex defines in parentheses' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).