LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Alexey Bayduraev <alexey.v.bayduraev@linux.intel.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Andi Kleen <ak@linux.intel.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Alexander Antonov <alexander.antonov@linux.intel.com>,
Alexei Budankov <abudankov@huawei.com>,
Riccardo Mancini <rickyman7@gmail.com>
Subject: [PATCH v4 7/8] perf session: Introduce reader return codes
Date: Wed, 13 Oct 2021 12:06:41 +0300 [thread overview]
Message-ID: <5fca481e91c3c5d2ba033d4c6e9b969f8033ab0f.1634113027.git.alexey.v.bayduraev@linux.intel.com> (raw)
In-Reply-To: <cover.1634113027.git.alexey.v.bayduraev@linux.intel.com>
Adding reader READER_OK and READER_NODATA return codes to make
the code more clear.
Suggested-by: Jiri Olsa <jolsa@kernel.org>
Acked-by: Namhyung Kim <namhyung@gmail.com>
Reviewed-by: Riccardo Mancini <rickyman7@gmail.com>
Tested-by: Riccardo Mancini <rickyman7@gmail.com>
Signed-off-by: Alexey Bayduraev <alexey.v.bayduraev@linux.intel.com>
---
tools/perf/util/session.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
index 68d130fe51c2..9714881839e3 100644
--- a/tools/perf/util/session.c
+++ b/tools/perf/util/session.c
@@ -2258,12 +2258,17 @@ reader__mmap(struct reader *rd, struct perf_session *session)
return 0;
}
+enum {
+ READER_OK,
+ READER_NODATA,
+};
+
static int
reader__read_event(struct reader *rd, struct perf_session *session,
struct ui_progress *prog)
{
u64 size;
- int err = 0;
+ int err = READER_OK;
union perf_event *event;
s64 skip;
@@ -2273,7 +2278,7 @@ reader__read_event(struct reader *rd, struct perf_session *session,
return PTR_ERR(event);
if (!event)
- return 1;
+ return READER_NODATA;
size = event->header.size;
@@ -2325,7 +2330,7 @@ reader__process_events(struct reader *rd, struct perf_session *session,
err = reader__read_event(rd, session, prog);
if (err < 0)
goto out;
- else if (err == 1)
+ else if (err == READER_NODATA)
goto remap;
if (session_done())
--
2.19.0
next prev parent reply other threads:[~2021-10-13 9:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 9:06 [PATCH v3 0/8] perf session: Extend reader object to allow multiple readers Alexey Bayduraev
2021-10-13 9:06 ` [PATCH v4 1/8] perf session: Move all state items to reader object Alexey Bayduraev
2021-10-13 9:06 ` [PATCH v4 2/8] perf session: Introduce decompressor in " Alexey Bayduraev
2021-10-13 9:06 ` [PATCH v4 3/8] perf session: Move init/release code to separate functions Alexey Bayduraev
2021-10-13 9:06 ` [PATCH v4 4/8] perf session: Move map code to separate function Alexey Bayduraev
2021-10-13 9:06 ` [PATCH v4 5/8] perf session: Move unmap code to reader__mmap Alexey Bayduraev
2021-10-13 9:06 ` [PATCH v4 6/8] perf session: Move event read code to separate function Alexey Bayduraev
2021-10-13 9:06 ` Alexey Bayduraev [this message]
2021-10-13 9:06 ` [PATCH v4 8/8] perf session: Introduce reader EOF function Alexey Bayduraev
2021-10-13 9:17 ` [PATCH v3 0/8] perf session: Extend reader object to allow multiple readers Bayduraev, Alexey V
2021-10-14 6:45 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fca481e91c3c5d2ba033d4c6e9b969f8033ab0f.1634113027.git.alexey.v.bayduraev@linux.intel.com \
--to=alexey.v.bayduraev@linux.intel.com \
--cc=abudankov@huawei.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.antonov@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rickyman7@gmail.com \
--subject='Re: [PATCH v4 7/8] perf session: Introduce reader return codes' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).