LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Pete MacKay" <linux01@architechnical.net>
To: broonie@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org
Cc: liam.girdwood@wolfsonmicro.com
Subject: Re: [PATCH] Core driver for WM97xx touchscreens
Date: Mon, 11 Feb 2008 19:00:30 -0500 (EST)	[thread overview]
Message-ID: <60949.69.30.58.166.1202774430.squirrel@architechnical.net> (raw)

In wm97xx-core.c, should

> +int wm97xx_resume(struct device *dev)

be static?

Also, should

> +		if (wm->ts_use_count) {

have been changed to

> +		if (wm->input_dev->users) {

in this revised revision?

(Oops, that was repetitively redundant. :)



             reply	other threads:[~2008-02-12  0:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-12  0:00 Pete MacKay [this message]
2008-02-12  9:46 ` Mark Brown
  -- strict thread matches above, loose matches on Subject: below --
2008-02-08 11:27 [PATCH 1/6] " Mark Brown
2008-02-08 11:27 ` [PATCH] " Mark Brown
2008-01-18 16:26 [UPDATED] WM97xx touchscreen drivers Mark Brown
2008-01-18 16:27 ` [PATCH] Core driver for WM97xx touchscreens Mark Brown
2008-01-18 17:23   ` Dmitry Torokhov
2008-01-18 18:11     ` Dmitry Baryshkov
2008-01-18 21:57       ` Ben Dooks
2008-01-19 19:53         ` Dmitry Baryshkov
2008-01-19 17:00       ` Mark Brown
2008-01-19 19:48         ` Dmitry
2008-01-19 21:55           ` Mark Brown
2008-01-19 22:18             ` Dmitry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=60949.69.30.58.166.1202774430.squirrel@architechnical.net \
    --to=linux01@architechnical.net \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=liam.girdwood@wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH] Core driver for WM97xx touchscreens' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).