LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Michael Riesch <michael.riesch@wolfvision.net>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
	linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Giuseppe Cavallaro <peppe.cavallaro@st.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Jose Abreu <joabreu@synopsys.com>,
	"David S . Miller" <davem@davemloft.net>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>
Subject: Re: [PATCH] net: stmmac: dwmac-rk: fix unbalanced pm_runtime_enable warnings
Date: Wed, 25 Aug 2021 10:07:48 +0200	[thread overview]
Message-ID: <60b707af-b138-3c31-726d-d78ac0e1c5f4@wolfvision.net> (raw)
In-Reply-To: <20210823094425.78d7a73e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>

Hi Jakub,

On 8/23/21 6:44 PM, Jakub Kicinski wrote:
> On Mon, 23 Aug 2021 16:37:54 +0200 Michael Riesch wrote:
>> In the commit to be reverted, support for power management was
>> introduced to the Rockchip glue code. Later, power management support
>> was introduced to the stmmac core code, resulting in multiple
>> invocations of pm_runtime_{enable,disable,get_sync,put_sync}.
> 
> Can we get a Fixes tag? I.e. reference to the earliest commit where 
> the warning can be triggered?

Of course :-)

Fixes: 5ec55823438e850c91c6b92aec93fb04ebde29e2 ("net: stmmac: add
clocks management for gmac driver")

This commit introduces power management support to the stmmac core
(stmmac_{dvr_probe, dvr_remove, suspend, resume}).

Best regards,
Michael

>> The multiple invocations happen in rk_gmac_powerup and
>> stmmac_{dvr_probe, resume} as well as in rk_gmac_powerdown and
>> stmmac_{dvr_remove, suspend}, respectively, which are always called
>> in conjunction.

  reply	other threads:[~2021-08-25  8:08 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-23 14:37 Michael Riesch
2021-08-23 16:44 ` Jakub Kicinski
2021-08-25  8:07   ` Michael Riesch [this message]
2021-08-25  9:50 ` patchwork-bot+netdevbpf
2021-08-29 17:48 ` Chen-Yu Tsai
2021-08-30  7:57   ` Michael Riesch
2021-08-30 13:49     ` Punit Agrawal
2021-08-30 14:10       ` Michael Riesch
2021-09-17  2:22         ` Qu Wenruo
2021-09-17  7:18           ` Punit Agrawal
2021-09-17  8:02             ` Qu Wenruo
2021-09-17 15:11               ` Punit Agrawal
2021-08-30 16:03     ` Chen-Yu Tsai
2021-08-30 19:22     ` Sasha Levin
2021-09-14  1:10 Ivan Babrou
2021-09-14 10:06 ` Michael Riesch
2021-09-14 13:39   ` Sebastian Döring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=60b707af-b138-3c31-726d-d78ac0e1c5f4@wolfvision.net \
    --to=michael.riesch@wolfvision.net \
    --cc=alexandre.torgue@foss.st.com \
    --cc=davem@davemloft.net \
    --cc=joabreu@synopsys.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=peppe.cavallaro@st.com \
    --subject='Re: [PATCH] net: stmmac: dwmac-rk: fix unbalanced pm_runtime_enable warnings' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).