LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: jolsa@redhat.com, acme@redhat.com, kstewart@linuxfoundation.org,
	tglx@linutronix.de, pombredanne@nexb.com,
	linux-kernel@vger.kernel.org, peterz@infradead.org,
	mingo@redhat.com, alexander.shishkin@linux.intel.com,
	namhyung@kernel.org, uneedsihyeon@gmail.com,
	kjlx@templeofstupid.com,
	Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Subject: Re: [PATCH v2 3/3] perf/buildid-cache: Support --purge-all option
Date: Wed, 9 May 2018 11:30:43 +0530	[thread overview]
Message-ID: <60b9c453-72a2-3fc7-71c7-e03eabd819ce@linux.ibm.com> (raw)
In-Reply-To: <20180509004257.9ad74de57b9e0f90ad5e7e81@kernel.org>



On 05/08/2018 09:12 PM, Masami Hiramatsu wrote:
> On Thu, 3 May 2018 14:24:04 +0530
> Ravi Bangoria <ravi.bangoria@linux.ibm.com> wrote:
>
>> Hi Masami,
>>
>> On 04/23/2018 12:32 PM, Masami Hiramatsu wrote:
>>> On Tue, 17 Apr 2018 09:43:46 +0530
>>> Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> wrote:
>>>
>>>> +	pr_debug("Purged all: %s\n", err ? "FAIL" : "Ok");
>>> Hmm, I think this should use pr_info(or pr_warning), at least for Failure case.
>> Actually, I followed what is already there for other options.
> Please see cmd_buildid_cache(), if we failed to purge one buildid-cache,
> it is warned with pr_warning.

Oh ok. I thought you are asking me to change pr_debug().
I'll quickly prepare and send a patch.

Thanks,
Ravi

>
> 	if (purge_name_list_str) {
> 		list = strlist__new(purge_name_list_str, NULL);
> 		if (list) {
> 			strlist__for_each_entry(pos, list)
> 				if (build_id_cache__purge_path(pos->s, nsi)) {
> 					if (errno == ENOENT) {
> 						pr_debug("%s wasn't in the cache\n",
> 							 pos->s);
> 						continue;
> 					}
> 					pr_warning("Couldn't remove %s: %s\n",
> 						   pos->s, str_error_r(errno, sbuf, sizeof(sbuf)));
> 				}
>
> 			strlist__delete(list);
> 		}
> 	}
>
> Thank you,
>

  reply	other threads:[~2018-05-09  6:00 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-17  4:13 [PATCH v2 0/3] perf/buildid-cache: Add --list and --purge-all options Ravi Bangoria
2018-04-17  4:13 ` [PATCH v2 1/3] tools/parse-options: Add '\n' at the end of error messages Ravi Bangoria
2018-04-21  7:52   ` [tip:perf/urgent] perf tools: Add '\n' at the end of parse-options " tip-bot for Ravi Bangoria
2018-04-17  4:13 ` [PATCH v2 2/3] perf/buildid-cache: Support --list option Ravi Bangoria
2018-04-23  6:59   ` Masami Hiramatsu
2018-05-02 17:39   ` [tip:perf/core] perf buildid-cache: " tip-bot for Ravi Bangoria
2018-04-17  4:13 ` [PATCH v2 3/3] perf/buildid-cache: Support --purge-all option Ravi Bangoria
2018-04-23  7:02   ` Masami Hiramatsu
2018-05-03  8:54     ` Ravi Bangoria
2018-05-08 15:42       ` Masami Hiramatsu
2018-05-09  6:00         ` Ravi Bangoria [this message]
2018-04-23 18:59   ` Arnaldo Carvalho de Melo
2018-05-02 17:40   ` [tip:perf/core] perf buildid-cache: " tip-bot for Ravi Bangoria
2018-04-17  7:57 ` [PATCH v2 0/3] perf/buildid-cache: Add --list and --purge-all options Jiri Olsa
2018-04-17 13:58   ` Arnaldo Carvalho de Melo
2018-04-18  5:54 ` Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=60b9c453-72a2-3fc7-71c7-e03eabd819ce@linux.ibm.com \
    --to=ravi.bangoria@linux.ibm.com \
    --cc=acme@redhat.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=jolsa@redhat.com \
    --cc=kjlx@templeofstupid.com \
    --cc=kstewart@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=pombredanne@nexb.com \
    --cc=tglx@linutronix.de \
    --cc=uneedsihyeon@gmail.com \
    --subject='Re: [PATCH v2 3/3] perf/buildid-cache: Support --purge-all option' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).