LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Qian Cai <cai@lca.pw>
To: "Theodore Y. Ts'o" <tytso@mit.edu>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: Signed-off-by missing for commit in the random tree
Date: Tue, 14 Jan 2020 12:31:04 -0500	[thread overview]
Message-ID: <613F42EB-F993-4F39-AD9B-A86E06A875AA@lca.pw> (raw)
In-Reply-To: <20200114165739.GB140865@mit.edu>



> On Jan 14, 2020, at 11:57 AM, Theodore Y. Ts'o <tytso@mit.edu> wrote:
> 
> On Tue, Jan 14, 2020 at 10:22:21AM +0900, Sergey Senozhatsky wrote:
>> 
>> Oh, I didn't realize I was the author. Sorry!
>> 
>> Sure, confirmed
>> 
>> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
>> 
> 
> Hmm... the e-mail in question[1] was sent by Qian Cai, but there was a
> 
>   From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
> 
> in the first line of the body which attributed the patch to you.  But
> then e-mail continues:
> 
>   Sergey didn't like the locking order .... but those code is so old,
>   and I have no clue how to de-couple it after checking other locks in
>   the splat. There is an onging effort to make all printk() as deferred,
>   so until that happens, workaround it for now as a short-term fix.
> 
> So did Qian Cai author the patch, and this should have been
> "Reported-by Sergey Senozhatsky"?  In which case I need a
> Signed-off-by from Qian Cai.
> 
> This is a pretty trivial patch, but it would be good to get the
> attributions and credit correct!
> 
> 						- Ted
> 
> [1] https://lore.kernel.org/linux-arm-kernel/1573679785-21068-1-git-send-email-cai@lca.pw/

It is actually Sergey proposed an informal patch here [1]. I just sent on
his behave and adding a commit log.

[1] https://lore.kernel.org/linux-mm/20190911011008.GA4420@jagdpanzerIV/ 


  reply	other threads:[~2020-01-14 17:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-08  0:39 Stephen Rothwell
2020-01-14  0:18 ` Theodore Y. Ts'o
2020-01-14  1:22   ` Sergey Senozhatsky
2020-01-14 16:57     ` Theodore Y. Ts'o
2020-01-14 17:31       ` Qian Cai [this message]
2020-01-14 21:33         ` Theodore Y. Ts'o
2020-01-14 21:41           ` Qian Cai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=613F42EB-F993-4F39-AD9B-A86E06A875AA@lca.pw \
    --to=cai@lca.pw \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sergey.senozhatsky.work@gmail.com \
    --cc=sfr@canb.auug.org.au \
    --cc=tytso@mit.edu \
    --subject='Re: linux-next: Signed-off-by missing for commit in the random tree' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).