LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH linux-next] firmware/psci: fix application of sizeof to pointer
@ 2021-08-20  2:30 jing yangyang
  2021-08-24 10:58 ` Mark Rutland
  0 siblings, 1 reply; 4+ messages in thread
From: jing yangyang @ 2021-08-20  2:30 UTC (permalink / raw)
  To: Mark Rutland
  Cc: Lorenzo Pieralisi, linux-arm-kernel, linux-kernel, jing yangyang,
	Zeal Robot

sizeof when applied to a pointer typed expression gives the size of
the pointer.

./drivers/firmware/psci/psci_checker.c:158:41-47: ERROR application of sizeof to pointer

This issue was detected with the help of Coccinelle.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: jing yangyang <jing.yangyang@zte.com.cn>
---
 drivers/firmware/psci/psci_checker.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/psci/psci_checker.c b/drivers/firmware/psci/psci_checker.c
index 9a369a2..116eb46 100644
--- a/drivers/firmware/psci/psci_checker.c
+++ b/drivers/firmware/psci/psci_checker.c
@@ -155,7 +155,7 @@ static int alloc_init_cpu_groups(cpumask_var_t **pcpu_groups)
 	if (!alloc_cpumask_var(&tmp, GFP_KERNEL))
 		return -ENOMEM;
 
-	cpu_groups = kcalloc(nb_available_cpus, sizeof(cpu_groups),
+	cpu_groups = kcalloc(nb_available_cpus, sizeof(*cpu_groups),
 			     GFP_KERNEL);
 	if (!cpu_groups) {
 		free_cpumask_var(tmp);
-- 
1.8.3.1



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-10-18 13:56 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-20  2:30 [PATCH linux-next] firmware/psci: fix application of sizeof to pointer jing yangyang
2021-08-24 10:58 ` Mark Rutland
2021-10-16 18:10   ` Gustavo A. R. Silva
2021-10-18 13:54     ` Sudeep Holla

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).