From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754727AbeDYO4D (ORCPT ); Wed, 25 Apr 2018 10:56:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40230 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754196AbeDYOz6 (ORCPT ); Wed, 25 Apr 2018 10:55:58 -0400 Date: Wed, 25 Apr 2018 10:55:57 -0400 (EDT) From: Pankaj Gupta To: Eric Blake Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, qemu-devel@nongnu.org, linux-nvdimm@ml01.01.org, linux-mm@kvack.org, kwolf@redhat.com, haozhong zhang , jack@suse.cz, xiaoguangrong eric , riel@surriel.com, niteshnarayanlal@hotmail.com, david@redhat.com, ross zwisler , lcapitulino@redhat.com, hch@infradead.org, mst@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, marcel@redhat.com, imammedo@redhat.com, dan j williams , nilal@redhat.com Message-ID: <634642140.22649359.1524668157371.JavaMail.zimbra@redhat.com> In-Reply-To: <25f3e433-cfa6-4a62-ba7f-47aef1119dfc@redhat.com> References: <20180425112415.12327-1-pagupta@redhat.com> <20180425112415.12327-4-pagupta@redhat.com> <25f3e433-cfa6-4a62-ba7f-47aef1119dfc@redhat.com> Subject: Re: [Qemu-devel] [RFC v2] qemu: Add virtio pmem device MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.116.111, 10.4.195.1] Thread-Topic: qemu: Add virtio pmem device Thread-Index: Eonhq2j8h5ewHvkm9qa3Zisytq9mkw== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > On 04/25/2018 06:24 AM, Pankaj Gupta wrote: > > This patch adds virtio-pmem Qemu device. > > > > This device presents memory address range > > information to guest which is backed by file > > backend type. It acts like persistent memory > > device for KVM guest. Guest can perform read > > and persistent write operations on this memory > > range with the help of DAX capable filesystem. > > > > Persistent guest writes are assured with the > > help of virtio based flushing interface. When > > guest userspace space performs fsync on file > > fd on pmem device, a flush command is send to > > Qemu over VIRTIO and host side flush/sync is > > done on backing image file. > > > > This PV device code is dependent and tested > > with 'David Hildenbrand's ' patchset[1] to > > map non-PCDIMM devices to guest address space. > > This sentence doesn't belong in git history. It is better to put > information like this... > > > There is still upstream discussion on using > > among PCI bar vs memory device, will update > > as per concensus. > > s/concensus/consensus/ > > > > > [1] https://marc.info/?l=qemu-devel&m=152450249319168&w=2 > > > > Signed-off-by: Pankaj Gupta > > --- > > ...here, where it is part of the email, but not picked up by 'git am'. I see. Thanks! > > > > +++ b/qapi/misc.json > > @@ -2871,6 +2871,29 @@ > > } > > } > > > > +## > > +# @VirtioPMemDeviceInfo: > > +# > > +# VirtioPMem state information > > +# > > +# @id: device's ID > > +# > > +# @start: physical address, where device is mapped > > +# > > +# @size: size of memory that the device provides > > +# > > +# @memdev: memory backend linked with device > > +# > > +# Since: 2.13 > > +## > > +{ 'struct': 'VirtioPMemDeviceInfo', > > + 'data': { '*id': 'str', > > + 'start': 'size', > > + 'size': 'size', > > TAB damage. o.k > > > + 'memdev': 'str' > > + } > > +} > > + > > ## > > # @MemoryDeviceInfo: > > # > > @@ -2880,7 +2903,8 @@ > > ## > > { 'union': 'MemoryDeviceInfo', > > 'data': { 'dimm': 'PCDIMMDeviceInfo', > > - 'nvdimm': 'PCDIMMDeviceInfo' > > + 'nvdimm': 'PCDIMMDeviceInfo', > > + 'virtio-pmem': 'VirtioPMemDeviceInfo' > > } > > } > > > > > > -- > Eric Blake, Principal Software Engineer > Red Hat, Inc. +1-919-301-3266 > Virtualization: qemu.org | libvirt.org > >