LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] scsi: ufs: ufshpb: Remove unused parameters
       [not found] <CGME20210831071227epcas1p188440324d4e68fb5c5ab506e02ee11e7@epcas1p1.samsung.com>
@ 2021-08-31  7:04 ` Chanwoo Lee
  2021-08-31 15:14   ` Bart Van Assche
  0 siblings, 1 reply; 3+ messages in thread
From: Chanwoo Lee @ 2021-08-31  7:04 UTC (permalink / raw)
  To: alim.akhtar, avri.altman, jejb, martin.petersen, daejun7.park,
	beanhuo, stanley.chu, keosung.park, linux-scsi, linux-kernel
  Cc: grant.jung, jt77.jang, dh0421.hwang, sh043.lee, ChanWoo Lee

From: ChanWoo Lee <cw9316.lee@samsung.com>

Remove unused parameters
* ufshpb_set_hpb_read_to_upiu()
 -> struct ufshpb_lu *hpb
 -> u32 lpn

Signed-off-by: ChanWoo Lee <cw9316.lee@samsung.com>
---
 drivers/scsi/ufs/ufshpb.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/scsi/ufs/ufshpb.c b/drivers/scsi/ufs/ufshpb.c
index 02fb51ae8b25..589af5f6b940 100644
--- a/drivers/scsi/ufs/ufshpb.c
+++ b/drivers/scsi/ufs/ufshpb.c
@@ -333,9 +333,8 @@ ufshpb_get_pos_from_lpn(struct ufshpb_lu *hpb, unsigned long lpn, int *rgn_idx,
 }
 
 static void
-ufshpb_set_hpb_read_to_upiu(struct ufs_hba *hba, struct ufshpb_lu *hpb,
-			    struct ufshcd_lrb *lrbp, u32 lpn, __be64 ppn,
-			    u8 transfer_len, int read_id)
+ufshpb_set_hpb_read_to_upiu(struct ufs_hba *hba, struct ufshcd_lrb *lrbp,
+			    __be64 ppn, u8 transfer_len, int read_id)
 {
 	unsigned char *cdb = lrbp->cmd->cmnd;
 	__be64 ppn_tmp = ppn;
@@ -703,8 +702,7 @@ int ufshpb_prep(struct ufs_hba *hba, struct ufshcd_lrb *lrbp)
 		}
 	}
 
-	ufshpb_set_hpb_read_to_upiu(hba, hpb, lrbp, lpn, ppn, transfer_len,
-				    read_id);
+	ufshpb_set_hpb_read_to_upiu(hba, lrbp, ppn, transfer_len, read_id);
 
 	hpb->stats.hit_cnt++;
 	return 0;
-- 
2.29.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] scsi: ufs: ufshpb: Remove unused parameters
  2021-08-31  7:04 ` [PATCH] scsi: ufs: ufshpb: Remove unused parameters Chanwoo Lee
@ 2021-08-31 15:14   ` Bart Van Assche
       [not found]     ` <CGME20210901004146epcas1p336b99f1c66e27c2df92982e6fc796b22@epcas1p3.samsung.com>
  0 siblings, 1 reply; 3+ messages in thread
From: Bart Van Assche @ 2021-08-31 15:14 UTC (permalink / raw)
  To: Chanwoo Lee, alim.akhtar, avri.altman, jejb, martin.petersen,
	daejun7.park, beanhuo, stanley.chu, keosung.park, linux-scsi,
	linux-kernel
  Cc: grant.jung, jt77.jang, dh0421.hwang, sh043.lee

On 8/31/21 00:04, Chanwoo Lee wrote:
> From: ChanWoo Lee <cw9316.lee@samsung.com>
> 
> Remove unused parameters
> * ufshpb_set_hpb_read_to_upiu()
>   -> struct ufshpb_lu *hpb
>   -> u32 lpn

Please use full sentences in the patch description for future patch 
submissions. Anyway:

Reviewed-by: Bart Van Assche <bvanassche@acm.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Re: [PATCH] scsi: ufs: ufshpb: Remove unused parameters
       [not found]     ` <CGME20210901004146epcas1p336b99f1c66e27c2df92982e6fc796b22@epcas1p3.samsung.com>
@ 2021-09-01  0:34       ` Chanwoo Lee
  0 siblings, 0 replies; 3+ messages in thread
From: Chanwoo Lee @ 2021-09-01  0:34 UTC (permalink / raw)
  To: bvanassche
  Cc: alim.akhtar, avri.altman, beanhuo, cw9316.lee, daejun7.park,
	dh0421.hwang, grant.jung, jejb, jt77.jang, keosung.park,
	linux-kernel, linux-scsi, martin.petersen, sh043.lee,
	stanley.chu

>On 8/31/21 00:04, Chanwoo Lee wrote:
>> From: ChanWoo Lee <cw9316.lee@samsung.com>
>> 
>> Remove unused parameters
>> * ufshpb_set_hpb_read_to_upiu()
>>   -> struct ufshpb_lu *hpb
>>   -> u32 lpn
>
>Please use full sentences in the patch description for future patch 
>submissions. Anyway:
>
>Reviewed-by: Bart Van Assche <bvanassche@acm.org>

Thank you, I will edit the description and upload it again.//v2

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-09-01  0:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20210831071227epcas1p188440324d4e68fb5c5ab506e02ee11e7@epcas1p1.samsung.com>
2021-08-31  7:04 ` [PATCH] scsi: ufs: ufshpb: Remove unused parameters Chanwoo Lee
2021-08-31 15:14   ` Bart Van Assche
     [not found]     ` <CGME20210901004146epcas1p336b99f1c66e27c2df92982e6fc796b22@epcas1p3.samsung.com>
2021-09-01  0:34       ` Chanwoo Lee

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).