LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Schrempf Frieder <frieder.schrempf@kontron.de>
To: Jeff Kletsky <lede@allycomm.com>,
	Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Boris Brezillon <bbrezillon@kernel.org>,
	Richard Weinberger <richard@nod.at>,
	David Woodhouse <dwmw2@infradead.org>,
	Brian Norris <computersforpeace@gmail.com>,
	Marek Vasut <marek.vasut@gmail.com>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kbuild-all@01.org" <kbuild-all@01.org>
Subject: Re: [PATCH v4 0/3] mtd: spinand: Add support for GigaDevice GD5F1GQ4UFxxG
Date: Thu, 23 May 2019 06:56:10 +0000	[thread overview]
Message-ID: <6351c1d6-c284-6bca-3914-3895d847c9c3@kontron.de> (raw)
In-Reply-To: <20190522220555.11626-1-lede@allycomm.com>

Hi Jeff,

On 23.05.19 00:05, Jeff Kletsky wrote:
> Addresses changes in macros and related data structures introduced by
>    commit 377e517b5fa5
>        mtd: nand: Add max_bad_eraseblocks_per_lun info to memorg
> 
> Resolves issue detected by kbuild test robot
>    Tue, 21 May 2019 17:28:09 +0800
>    Tue, 21 May 2019 18:17:28 +0800
> 
> GD5F1GQ4UFxxG data sheet on page 34 of gd5f1gq4xfxxg_v2.4_20190322.pdf
> indicates "Minumum number of valid blocks (Nvb)" 1004 out of 1024 total.
> 
> Newly introduced "max bad blocks" parameter set to 20 (1024-1020).
> 
> Rebased on v5.2-rc1 and confirmed patch applies on master.
> 
> 
> Patches 1/3 and 2/3 are the same as in the previous series.
> 
> Patch 3/3, mtd: spinand: Add support for GigaDevice GD5F1GQ4UFxxG,
> includes the additional parameter (compared here to v3 of the series):
> 
>      SPINAND_INFO("GD5F1GQ4UFxxG", 0xb148,
>      -                    NAND_MEMORG(1, 2048, 128, 64, 1024, 1, 1, 1),
>      +                    NAND_MEMORG(1, 2048, 128, 64, 1024, 20, 1, 1, 1),
>                           NAND_ECCREQ(8, 512),
>                           SPINAND_INFO_OP_VARIANTS(&read_cache_variants_f,
>                           &write_cache_variants,
> 
> R-b of Frieder Schrempf removed from [3/3] as a result this change.

As to what I know, this would not have been necessary in this case. I 
missed the missing parameter while reviewing and you fixed it with this 
new version, so you obviously improved the patch with a minor change and 
it wouldn't be working without this anyway. So I think in such cases you 
would typically keep the R-b tags.

Also if you drop the R-b tag from one of the patches in your set, you 
should instead CC the reviewer for the whole set. Otherwise 
get_maintainer will only CC the reviewer for those patches that contain 
his tag. In this case I wasn't CCed for patch 3/3.

Thanks,
Frieder

> 
> Supersedes series:
> 
> mtd: spinand: Add support for GigaDevice GD5F1GQ4UFxxG
> https://patchwork.ozlabs.org/project/linux-mtd/list/?series=108868
> 
> 
> 
> Jeff
> 
> 
> 
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Schrempf Frieder <frieder.schrempf@kontron.de>
> Cc: Boris Brezillon <bbrezillon@kernel.org>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: Brian Norris <computersforpeace@gmail.com>
> Cc: Marek Vasut <marek.vasut@gmail.com>
> Cc: linux-mtd@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Cc: kbuild-all@01.org
> 
> 
> 

      parent reply	other threads:[~2019-05-23  6:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-22 22:05 Jeff Kletsky
2019-05-22 22:05 ` [PATCH v4 1/3] mtd: spinand: Define macros for page-read ops with three-byte addresses Jeff Kletsky
2019-06-03  8:02   ` Miquel Raynal
2019-05-22 22:05 ` [PATCH v4 2/3] mtd: spinand: Add support for two-byte device IDs Jeff Kletsky
2019-06-03  8:02   ` Miquel Raynal
2019-05-22 22:05 ` [PATCH v4 3/3] mtd: spinand: Add support for GigaDevice GD5F1GQ4UFxxG Jeff Kletsky
2019-05-23  6:42   ` Schrempf Frieder
2019-05-24  0:12     ` Jeff Kletsky
2019-05-27  6:35       ` Schrempf Frieder
2019-05-27  9:28         ` Miquel Raynal
2019-06-03  8:02   ` Miquel Raynal
2019-05-23  6:56 ` Schrempf Frieder [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6351c1d6-c284-6bca-3914-3895d847c9c3@kontron.de \
    --to=frieder.schrempf@kontron.de \
    --cc=bbrezillon@kernel.org \
    --cc=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=kbuild-all@01.org \
    --cc=lede@allycomm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marek.vasut@gmail.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --subject='Re: [PATCH v4 0/3] mtd: spinand: Add support for GigaDevice GD5F1GQ4UFxxG' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).