LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Coelho, Luciano" <email@example.com>
To: "firstname.lastname@example.org" <email@example.com>,
Cc: "firstname.lastname@example.org" <email@example.com>,
"Korenblit, Miriam Rachel" <firstname.lastname@example.org>,
Subject: Re: [GIT PULL] Networking for v5.15
Date: Thu, 2 Sep 2021 09:33:02 +0000 [thread overview]
Message-ID: <email@example.com> (raw)
On Wed, 2021-09-01 at 21:49 +0200, Johannes Berg wrote:
> On Wed, 2021-09-01 at 12:41 -0700, Jakub Kicinski wrote:
> > >
> > > They all seem to have that same issue, and it looks like the fix would
> > > be to get the RTN lock in iwl_mvm_init_mcc(), but I didn't really look
> > > into it very much.
> > >
> > > This is on my desktop, and I actually don't _use_ the wireless on this
> > > machine. I assume it still works despite the warnings, but they should
> > > get fixed.
> > >
> > > I *don't* see these warnings on my laptop where I actually use
> > > wireless, but that one uses ath10k_pci, so it seems this is purely a
> > > iwlwifi issue.
> > >
> > > I can't be the only one that sees this. Hmm?
> > Mm. Looking thru the recent commits there is a suspicious rtnl_unlock()
> > in commit eb09ae93dabf ("iwlwifi: mvm: load regdomain at INIT stage").
> Huh! That's not the version of the commit I remember - it had an
> rtnl_lock() in there too (just before the mutex_lock)?! Looks like that
> should really be there, not sure how/where it got lost along the way.
> That unbalanced rtnl_unlock() makes no sense anyway. Wonder why it
> doesn't cause more assertions/problems at that point, clearly it's
> unbalanced. Pretty sure it's missing the rtnl_lock() earlier in the
> function for some reason.
> Luca and I will look at it tomorrow, getting late here, sorry.
Right, the reason for this was a rebase damage. We lost the
rtnl_lock() call when I rebased the patch on top of the tree without
iwlmei (which touch this same function).
Sorry for the trouble, I'll send the fix in a sec.
next prev parent reply other threads:[~2021-09-02 9:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-31 20:37 Jakub Kicinski
2021-08-31 23:56 ` pr-tracker-bot
2021-09-01 19:00 ` Linus Torvalds
2021-09-01 19:41 ` Jakub Kicinski
2021-09-01 19:49 ` Johannes Berg
2021-09-01 21:48 ` Larry Finger
2021-09-02 9:33 ` Coelho, Luciano [this message]
2021-09-02 10:11 ` [PATCH] iwlwifi: mvm: add rtnl_lock() in iwl_mvm_start_get_nvm() Luca Coelho
2021-09-02 10:39 ` David Miller
2021-09-02 15:55 ` Linus Torvalds
[not found] ` <CAP71bdV1eBm3f1qY0rfigK4VaW5icZ+hU0pw7g6fVM=hGbn7Xw@mail.gmail.com>
2021-09-02 17:16 ` [GIT PULL] Networking for v5.15 Linus Torvalds
2021-09-02 5:55 ` Larry Finger
2021-09-02 7:07 ` Johannes Berg
2021-09-02 0:02 ` John Stultz
2021-09-02 9:25 ` Dan Carpenter
2021-09-02 9:28 ` Srinivas Kandagatla
2021-09-02 10:08 ` [PATCH net] net: qrtr: revert check in qrtr_endpoint_post() Dan Carpenter
2021-09-02 10:40 ` patchwork-bot+netdevbpf
2021-09-04 3:08 ` [GIT PULL] Networking for v5.15 John Stultz
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--subject='Re: [GIT PULL] Networking for v5.15' \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).