LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: <sean.wang@mediatek.com> To: <robh+dt@kernel.org>, <mark.rutland@arm.com>, <sre@kernel.org>, <lee.jones@linaro.org>, <a.zummo@towertech.it>, <alexandre.belloni@free-electrons.com>, <matthias.bgg@gmail.com>, <eddie.huang@mediatek.com> Cc: <devicetree@vger.kernel.org>, <linux-rtc@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-pm@vger.kernel.org>, <linux-mediatek@lists.infradead.org>, <linux-kernel@vger.kernel.org>, Sean Wang <sean.wang@mediatek.com> Subject: [PATCH v2 10/17] rtc: mt6397: remove unnecessary irq_dispose_mapping Date: Wed, 25 Apr 2018 17:32:36 +0800 [thread overview] Message-ID: <6354082fb42b560b4f0a7d8ed32e7ae274d624a9.1524646231.git.sean.wang@mediatek.com> (raw) In-Reply-To: <cover.1524646231.git.sean.wang@mediatek.com> From: Sean Wang <sean.wang@mediatek.com> With the patch [1], the job irq_create_mapping had been moved from the rtc driver to mfd core, so it should be unnecessary to keep irq_dispose_mapping in all paths of the leaf driver. [1] http://lists.infradead.org/pipermail/linux-mediatek/2017-September/010455.html Signed-off-by: Sean Wang <sean.wang@mediatek.com> --- drivers/rtc/rtc-mt6397.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c index efb9370..398bae5 100644 --- a/drivers/rtc/rtc-mt6397.c +++ b/drivers/rtc/rtc-mt6397.c @@ -17,7 +17,6 @@ #include <linux/module.h> #include <linux/regmap.h> #include <linux/rtc.h> -#include <linux/irqdomain.h> #include <linux/jiffies.h> #include <linux/platform_device.h> #include <linux/of_address.h> @@ -336,7 +335,7 @@ static int mtk_rtc_probe(struct platform_device *pdev) if (ret) { dev_err(&pdev->dev, "Failed to request alarm IRQ: %d: %d\n", rtc->irq, ret); - goto out_dispose_irq; + return ret; } device_init_wakeup(&pdev->dev, 1); @@ -353,8 +352,7 @@ static int mtk_rtc_probe(struct platform_device *pdev) out_free_irq: free_irq(rtc->irq, rtc->rtc_dev); -out_dispose_irq: - irq_dispose_mapping(rtc->irq); + return ret; } @@ -364,7 +362,6 @@ static int mtk_rtc_remove(struct platform_device *pdev) rtc_device_unregister(rtc->rtc_dev); free_irq(rtc->irq, rtc->rtc_dev); - irq_dispose_mapping(rtc->irq); return 0; } -- 2.7.4
next prev parent reply other threads:[~2018-04-25 9:35 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-25 9:32 [PATCH v2 00/17] Add support to MT6323 RTC and its power device sean.wang 2018-04-25 9:32 ` [PATCH v2 01/17] dt-bindings: power: reset: mt6323: add bindings for MT6323 power controller sean.wang 2018-04-27 20:02 ` Rob Herring 2018-04-30 7:34 ` Sean Wang 2018-04-25 9:32 ` [PATCH v2 02/17] dt-bindings: rtc: mt6397: add bindings for MediaTek PMIC based RTC sean.wang 2018-05-08 15:39 ` Rob Herring 2018-04-25 9:32 ` [PATCH v2 03/17] dt-bindings: mfd: mt6397: add a description for MT6323 RTC sean.wang 2018-04-25 9:32 ` [PATCH v2 04/17] dt-bindings: mfd: mt6397: add a description for MT6323 power controller sean.wang 2018-04-25 9:32 ` [PATCH v2 05/17] mfd: mt6397: add MT6323 RTC support into MT6397 driver sean.wang 2018-04-25 9:32 ` [PATCH v2 06/17] mfd: mt6397: add support for MT6323 power controller " sean.wang 2018-04-25 9:32 ` [PATCH v2 07/17] mfd: mt6397: reuse DEFINE_RES_* helpers sean.wang 2018-04-25 9:32 ` [PATCH v2 08/17] rtc: mt6397: add MT6323 support to RTC driver sean.wang 2018-04-25 9:32 ` [PATCH v2 09/17] rtc: mt6397: replace a poll with regmap_read_poll_timeout sean.wang 2018-04-25 9:32 ` sean.wang [this message] 2018-04-25 9:32 ` [PATCH v2 11/17] rtc: mt6397: convert to use device managed functions sean.wang 2018-04-25 9:32 ` [PATCH v2 12/17] rtc: mt6397: move the declaration into a globally visible header file sean.wang 2018-04-25 9:32 ` [PATCH v2 13/17] rtc: mt6397: cleanup header files to include sean.wang 2018-04-25 9:32 ` [PATCH v2 14/17] rtc: mt6397: update license converting to using SPDX identifiers sean.wang 2018-04-25 9:32 ` [PATCH v2 15/17] power: reset: mt6323: add a driver for MT6323 power controller sean.wang 2018-05-01 12:56 ` Sebastian Reichel 2018-05-02 2:31 ` Sean Wang 2018-04-25 9:32 ` [PATCH v2 16/17] MAINTAINERS: update entry for ARM/Mediatek RTC DRIVER sean.wang 2018-04-25 9:32 ` [PATCH v2 17/17] MAINTAINERS: add an entry for MediaTek board level shutdown driver sean.wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=6354082fb42b560b4f0a7d8ed32e7ae274d624a9.1524646231.git.sean.wang@mediatek.com \ --to=sean.wang@mediatek.com \ --cc=a.zummo@towertech.it \ --cc=alexandre.belloni@free-electrons.com \ --cc=devicetree@vger.kernel.org \ --cc=eddie.huang@mediatek.com \ --cc=lee.jones@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-rtc@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=matthias.bgg@gmail.com \ --cc=robh+dt@kernel.org \ --cc=sre@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).