From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A895C433F5 for ; Mon, 8 Nov 2021 13:39:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5B20C61505 for ; Mon, 8 Nov 2021 13:39:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240007AbhKHNmU (ORCPT ); Mon, 8 Nov 2021 08:42:20 -0500 Received: from mga02.intel.com ([134.134.136.20]:2279 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230299AbhKHNmT (ORCPT ); Mon, 8 Nov 2021 08:42:19 -0500 X-IronPort-AV: E=McAfee;i="6200,9189,10161"; a="219423204" X-IronPort-AV: E=Sophos;i="5.87,218,1631602800"; d="scan'208";a="219423204" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Nov 2021 05:39:34 -0800 X-IronPort-AV: E=Sophos;i="5.87,218,1631602800"; d="scan'208";a="533315761" Received: from anushave-mobl1.amr.corp.intel.com (HELO [10.255.85.158]) ([10.255.85.158]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Nov 2021 05:39:31 -0800 Subject: Re: [PATCH] ASoC: SOF: build compression interface into snd_sof.ko To: Arnd Bergmann , Liam Girdwood , Ranjani Sridharan , Kai Vehmanen , Daniel Baluta Cc: Arnd Bergmann , Mark Brown , Jaroslav Kysela , Takashi Iwai , Colin Ian King , Peter Ujfalusi , Randy Dunlap , Bud Liviu-Alexandru , Paul Olaru , sound-open-firmware@alsa-project.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org References: <20211108111132.3800548-1-arnd@kernel.org> From: Pierre-Louis Bossart Message-ID: <63c5b1fb-575e-f026-5a76-f08a366f7f38@linux.intel.com> Date: Mon, 8 Nov 2021 07:39:29 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211108111132.3800548-1-arnd@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/8/21 5:11 AM, Arnd Bergmann wrote: > From: Arnd Bergmann > > With CONFIG_SND_SOC_SOF_COMPRESS=m, the compression code is > not built into a the main SOF driver when that is built-in: > > x86_64-linux-ld: sound/soc/sof/ipc.o: in function `ipc_stream_message': > ipc.c:(.text+0x5a2): undefined reference to `snd_sof_compr_fragment_elapsed' > x86_64-linux-ld: sound/soc/sof/topology.o: in function `sof_dai_load': > topology.c:(.text+0x32d1): undefined reference to `snd_sof_compr_init_elapsed_work' > x86_64-linux-ld: topology.c:(.text+0x32e1): undefined reference to `snd_sof_compr_init_elapsed_work' > > Make this a 'bool' symbol so it just decides whether the > code gets built at all. > > Fixes: 858f7a5c45ca ("ASoC: SOF: Introduce fragment elapsed notification API") > Signed-off-by: Arnd Bergmann It's Monday morning and my memory is still foggy but I think we fixed this problem with https://github.com/thesofproject/linux/pull/3180, where we changed the Kconfigs for i.MX. We haven't sent this update upstream for some reason. Arnd, can you share the configuration that breaks with the existing upstream code, I can check if the problem still exists. Thanks!