From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751871AbdKTWDp (ORCPT ); Mon, 20 Nov 2017 17:03:45 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:48760 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751834AbdKTWDk (ORCPT ); Mon, 20 Nov 2017 17:03:40 -0500 Subject: Re: [PATCH v5 5/8] dt-bindings: fsi: Add OCC documentation To: Rob Herring Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, devicetree@vger.kernel.org, mark.rutland@arm.com, bradleyb@fuzziesquirrel.com, cbostic@linux.vnet.ibm.com, joel@jms.id.au, "Edward A. James" References: <1511207217-14075-1-git-send-email-eajames@linux.vnet.ibm.com> <1511207217-14075-6-git-send-email-eajames@linux.vnet.ibm.com> <20171120213913.6j7qgcgobc2ocqey@rob-hp-laptop> From: Eddie James Date: Mon, 20 Nov 2017 16:03:33 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171120213913.6j7qgcgobc2ocqey@rob-hp-laptop> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-TM-AS-GCONF: 00 x-cbid: 17112022-0020-0000-0000-00000D08F930 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00008100; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000240; SDB=6.00948789; UDB=6.00479117; IPR=6.00729071; BA=6.00005702; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00018112; XFM=3.00000015; UTC=2017-11-20 22:03:37 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17112022-0021-0000-0000-00005EFCA0BF Message-Id: <647df116-c434-ae4e-8a16-54145f57ab5c@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-11-20_12:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1711200295 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/20/2017 03:39 PM, Rob Herring wrote: > On Mon, Nov 20, 2017 at 01:46:54PM -0600, Eddie James wrote: >> From: "Edward A. James" >> >> Document the bindings for the P9 OCC device. OCC devices are accessed >> through the SBEFIFO. >> >> Signed-off-by: Edward A. James >> --- >> Documentation/devicetree/bindings/fsi/ibm,p9-occ.txt | 18 ++++++++++++++++++ >> 1 file changed, 18 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/fsi/ibm,p9-occ.txt >> >> diff --git a/Documentation/devicetree/bindings/fsi/ibm,p9-occ.txt b/Documentation/devicetree/bindings/fsi/ibm,p9-occ.txt >> new file mode 100644 >> index 0000000..79094f5 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/fsi/ibm,p9-occ.txt >> @@ -0,0 +1,18 @@ >> +Device-tree bindings for P9 On-Chip Controller >> +---------------------------------------------- >> + >> +The POWER9 On-Chip Controller is accessed through the SBEFIFO. All OCC nodes >> +must be child nodes of SBEFIFO devices (see ibm,p9-sbefifo.txt). >> + >> +Required properties: >> + - compatible = "ibm,p9-occ"; >> + >> +Optional properties: >> + - reg = ; : Index for the processor this OCC is on. > reg should be how the parent (SBEFIFO) addresses this device. Would all > of these child devices be a unique processor? Yes. The "processor" here is indicating which P9 processor in the system, not whatever processor(s) this kernel is running on. We use this device tree on the service processor, which can be talking to multiple P9 chips (over SBEFIFO). This could probably be clarified by saying "P9 chip" or something. > > I think a phandle to the cpu node would be more appropriate here. No phandle available; see above, the processor being referenced is a separate entity in the system. Thanks for the quick feedback. Eddie > >> + >> +Examples: >> + >> + occ@1 { >> + compatible = "ibm,p9-occ"; >> + reg = <1>; >> + }; >> -- >> 1.8.3.1 >>