LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Guilherme G. Piccoli" <gpiccoli@canonical.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
	mcgrof@kernel.org, keescook@chromium.org, yzaikin@google.com,
	tglx@linutronix.de, kernel@gpiccoli.net
Subject: Re: [PATCH] panic: Add sysctl/cmdline to dump all CPUs backtraces on oops event
Date: Wed, 11 Mar 2020 09:46:45 -0300	[thread overview]
Message-ID: <64a6c1c0-9514-e823-3507-a131c7daa578@canonical.com> (raw)
In-Reply-To: <20200310182647.59f6ea73aad3aca619065f1e@linux-foundation.org>

On 10/03/2020 22:26, Andrew Morton wrote:
> On Tue, 10 Mar 2020 13:59:15 -0700 Randy Dunlap <rdunlap@infradead.org> wrote:
> 
>>> +oops_all_cpu_backtrace:
>>> +================
>>> +
>>> +Determines if kernel should NMI all CPUs to dump their backtraces when
>>
>> I would much prefer that to be written without using NMI as a verb.
> 
> "Non maskably interrupt" ;)
> 
> I think it's OK.  Concise and the meaning is clear.

Hi Andrew, good idea heheh
Thank you and all that reviewed the grammar/wording, certainly I can
change that and resubmit.


> 
> 
> Why do we need the kernel boot parameter?  Isn't
> /proc/sys/kernel/oops_all_cpu_backtrace sufficient?
> 

I kept the kernel parameter as a consistency thing - every sysctl
"*_all_cpubacktrace" has a respective kernel parameter, so I did the
same (and if we get an oops booting a new kernel, this is maybe useful
depending on the point we get the oops). But if it's a problem for you,
I can remove the kernel parameter, your choice.

Cheers,


Guilherme

  reply	other threads:[~2020-03-11 12:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-10 16:37 Guilherme G. Piccoli
2020-03-10 20:59 ` Randy Dunlap
2020-03-11  1:26   ` Andrew Morton
2020-03-11 12:46     ` Guilherme G. Piccoli [this message]
2020-03-14 14:28   ` Matthew Wilcox
2020-03-14 21:18     ` Randy Dunlap
2020-03-16 13:51       ` Guilherme G. Piccoli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=64a6c1c0-9514-e823-3507-a131c7daa578@canonical.com \
    --to=gpiccoli@canonical.com \
    --cc=akpm@linux-foundation.org \
    --cc=keescook@chromium.org \
    --cc=kernel@gpiccoli.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=yzaikin@google.com \
    --subject='Re: [PATCH] panic: Add sysctl/cmdline to dump all CPUs backtraces on oops event' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).