LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net> To: Eric Anholt <eric@anholt.net>, Kevin Hilman <khilman@kernel.org>, Ulf Hansson <ulf.hansson@linaro.org> Cc: linux-kernel@vger.kernel.org, Tomasz Figa <tomasz.figa@gmail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Linux PM list <linux-pm@vger.kernel.org> Subject: Re: [PATCH] PM / Domains: If an OF node is found but no device probed yet, defer. Date: Wed, 11 Mar 2015 23:08:11 +0100 [thread overview] Message-ID: <6516096.HanqZ05BXy@vostro.rjw.lan> (raw) In-Reply-To: <1426087648-3862-1-git-send-email-eric@anholt.net> More CCes. On Wednesday, March 11, 2015 08:27:28 AM Eric Anholt wrote: > If we've declared a power domain in the OF, and the OF node is found > but the requested domain hasn't been registered on it yet, then we > probably have just tried to probe before the power domain driver has. > Defer our device's probe until it shows up. > > Signed-off-by: Eric Anholt <eric@anholt.net> Kevin, Ulf, any chance to have a look at this, please? > --- > > I ran into this when turning my ad-hoc code for BCM2835 (Raspberry Pi) > USB poweron support in the DWC2 controller to an OF-based power domain > declaration. > > drivers/base/power/domain.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c > index ba4abbe..2b93c98 100644 > --- a/drivers/base/power/domain.c > +++ b/drivers/base/power/domain.c > @@ -2064,7 +2064,7 @@ EXPORT_SYMBOL_GPL(of_genpd_del_provider); > struct generic_pm_domain *of_genpd_get_from_provider( > struct of_phandle_args *genpdspec) > { > - struct generic_pm_domain *genpd = ERR_PTR(-ENOENT); > + struct generic_pm_domain *genpd = ERR_PTR(-EPROBE_DEFER); > struct of_genpd_provider *provider; > > mutex_lock(&of_genpd_mutex); > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2015-03-11 21:44 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-03-11 15:27 [PATCH] PM / Domains: If an OF node is found but no device probed yet, defer Eric Anholt 2015-03-11 22:08 ` Rafael J. Wysocki [this message] 2015-03-11 22:14 ` Geert Uytterhoeven 2015-03-12 19:31 ` Eric Anholt 2015-03-13 18:01 ` Kevin Hilman 2015-03-16 8:44 ` Geert Uytterhoeven 2015-03-16 10:12 ` Ulf Hansson 2015-03-18 22:55 ` Eric Anholt 2015-03-12 8:39 ` Ulf Hansson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=6516096.HanqZ05BXy@vostro.rjw.lan \ --to=rjw@rjwysocki.net \ --cc=eric@anholt.net \ --cc=gregkh@linuxfoundation.org \ --cc=khilman@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=tomasz.figa@gmail.com \ --cc=ulf.hansson@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).