LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Miguel Ojeda" <maxextreme@gmail.com>
To: "Alexey Dobriyan" <adobriyan@gmail.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] display: Driver ks0108 and cfag12864b
Date: Tue, 12 Sep 2006 04:37:53 +0200	[thread overview]
Message-ID: <653402b90609111937i1d986331kc5ed167cb08831b7@mail.gmail.com> (raw)
In-Reply-To: <20060912011346.GB5192@martell.zuzino.mipt.ru>

On 9/12/06, Alexey Dobriyan <adobriyan@gmail.com> wrote:
>
> arrrrggg....  I'm in the middle of reading every module_init and every
> module_exit func, and this starts getting really annoying....
>

Anyway, thank you for you time reviewing it. :)


>         5. In case of error during initialization, error code SHOULD be
>            propagated as is to upper layers, either via direct
>            assignment/return or via decoding from pointer.
>

What do you mean? I thought returning the error code was enough.


>         6. Error messages SHOULD start with short unique prefix specific to
>            driver. Module name without .o and .ko is fine.

They do 8)

#define PRINTK_PREFIX PRINTK_INFO NAME ": "

printk(PRINTK_PREFIX "Init... ");

Then, if a error appears: printk("ERROR - kmalloc\n");

Final string: "<i>cfag12864b: Init... ERROR - kmalloc"

The only bad point: If some other printk is called from other module
between. Should I change it?


    Miguel Ojeda

  reply	other threads:[~2006-09-12  2:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-11 23:27 [PATCH 2.6.17.13] " Miguel Ojeda
2006-09-11 23:54 ` [PATCH 1/2] " Miguel Ojeda
2006-09-11 23:57 ` [PATCH 2/2] " Miguel Ojeda
2006-09-12  1:13   ` Alexey Dobriyan
2006-09-12  2:37     ` Miguel Ojeda [this message]
2006-09-12  3:51 ` [PATCH 2.6.17.13] " Greg KH
2006-09-12  5:50   ` [PATCH V2] " Miguel Ojeda
2006-09-12  6:09   ` [PATCH 2.6.17.13] " Miguel Ojeda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=653402b90609111937i1d986331kc5ed167cb08831b7@mail.gmail.com \
    --to=maxextreme@gmail.com \
    --cc=adobriyan@gmail.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH 2/2] display: Driver ks0108 and cfag12864b' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).