From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5690FC4338F for ; Thu, 5 Aug 2021 19:32:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 254B661004 for ; Thu, 5 Aug 2021 19:32:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242064AbhHETcS (ORCPT ); Thu, 5 Aug 2021 15:32:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235225AbhHETcQ (ORCPT ); Thu, 5 Aug 2021 15:32:16 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68FE7C061765 for ; Thu, 5 Aug 2021 12:32:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject: Sender:Reply-To:Content-ID:Content-Description; bh=GbnUV28bxkOp7gCXE/AS1YBxe5QFYfSNYycGqaP8y10=; b=OH0IAeHpUImkTwBEYEVKJ/88ip pi2GLuVtwMBuBVg4pLCGAijvR1GC6Xa0X4zc5h9uwcYNJzsA0YGZ2FLOCxxFwsHmspsYuYFS4RX+4 qqeiHWTLUx/SWGArKspUWhXYS5IbLuBnvVv45iVz03el/CXwGb69HVCbebf8N68Aj/46CI7g0Dg0S 9EYwvXHaZ1LwXipPw+1Nd84MG1VlrVMIahWOqekza7QcB0YKdS+yFmkoJHW4S+8c2OHPYM3X+N808 VbEM+3k/orhmjIprEOydp/XXApn/zJIKqJaDIaVvh8P56iYP+c/zbeE8FD+K1y2U2dGi4SM3in4QO 98r2HgIA==; Received: from [2601:1c0:6280:3f0::aa0b] by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBj5i-0069hG-Ib; Thu, 05 Aug 2021 19:31:42 +0000 Subject: Re: [PATCH] openrisc: Fix compiler warnings in setup To: Stafford Horne , LKML Cc: Openrisc , kernel test robot , Jonas Bonn , Stefan Kristiansson , Mike Rapoport , Andrew Morton , Kefeng Wang , Christophe JAILLET References: <20210805030035.2994973-1-shorne@gmail.com> From: Randy Dunlap Message-ID: <655ef6e0-defb-7467-25df-f9a13ab96694@infradead.org> Date: Thu, 5 Aug 2021 12:31:37 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210805030035.2994973-1-shorne@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/4/21 8:00 PM, Stafford Horne wrote: > This was pointed out with the recent name change of or32_early_setup to > or1k_early_setup. Investigating the file I found a few other warnings > so cleaning them up here. > > arch/openrisc/kernel/setup.c:220:13: warning: no previous prototype for 'or1k_early_setup' [-Wmissing-prototypes] > 220 | void __init or1k_early_setup(void *fdt) > | ^~~~~~~~~~~~~~~~ > > Fix this the missing or1k_early_setup prototype warning by adding an > asm/setup.h file to define the prototype. > > arch/openrisc/kernel/setup.c:246:13: warning: no previous prototype for 'detect_unit_config' [-Wmissing-prototypes] > 246 | void __init detect_unit_config(unsigned long upr, unsigned long mask, > | ^~~~~~~~~~~~~~~~~~ > > The function detect_unit_config is not used, just remove it. > > arch/openrisc/kernel/setup.c:221: warning: Function parameter or member 'fdt' not described in 'or1k_early_setup' > > Add @fdt docs to the function comment to suppress this warning. > > Reported-by: kernel test robot > Signed-off-by: Stafford Horne Hi Stafford, Does this patch apply to your openrisc tree, but not to linux-next? I get a patch error when trying to apply it to linux-next-20210805 and this warning is still present: ../arch/openrisc/kernel/setup.c:221:13: warning: no previous prototype for 'or32_early_setup' [-Wmissing-prototypes] 221 | void __init or32_early_setup(void *fdt) | ^~~~~~~~~~~~~~~~ presumably because some openrisc patches are not yet in linux-next?? thanks. > --- > arch/openrisc/include/asm/setup.h | 14 ++++++++++++++ > arch/openrisc/kernel/setup.c | 16 +--------------- > 2 files changed, 15 insertions(+), 15 deletions(-) > create mode 100644 arch/openrisc/include/asm/setup.h > -- ~Randy