LKML Archive on
help / color / mirror / Atom feed
From: "Paul Menage" <>
To: "Peter Zijlstra" <>
Cc: "Pavel Emelyanov" <>,
	"Andrew Morton" <>,
	"Linux Containers" <>,
	"Linux Kernel Mailing List" <>
Subject: Re: [PATCH][DOCUMENTATION] Minimal controller code for a quick start
Date: Thu, 7 Feb 2008 12:49:25 -0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <1202416137.6274.42.camel@lappy>

On Feb 7, 2008 12:28 PM, Peter Zijlstra <> wrote:
> While on the subject, could someone document struct cgroup_subsys.

There's documentation for all the methods in Documentation/cgroup.txt

> particular, I've wondered why we have: cgroup_subsys::can_attach() and
> not use a return value in cgroup_subsys::attach()?

We could do in theory do that, but it would make the recovery logic in
cgroup.c:attach_task() more complex - it would have to be able to deal
with undoing a partial attach. It seems simpler to just split it into
two phases, given that most cgroups don't appear to have attachment
conditions anyway.


  reply	other threads:[~2008-02-07 20:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-07 15:37 Pavel Emelyanov
2008-02-07 20:28 ` Peter Zijlstra
2008-02-07 20:49   ` Paul Menage [this message]
2008-02-07 20:52     ` Peter Zijlstra
2008-02-07 20:50   ` Serge E. Hallyn
2008-02-07 20:45 ` Paul Menage
2008-02-08  8:09   ` Pavel Emelyanov
2008-02-07 20:47 ` Serge E. Hallyn
2008-02-08  9:28   ` Pavel Emelyanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \
    --subject='Re: [PATCH][DOCUMENTATION] Minimal controller code for a quick start' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).