LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Paul Menage" <menage@google.com>
To: "Peter Zijlstra" <a.p.zijlstra@chello.nl>
Cc: "Pavel Emelyanov" <xemul@openvz.org>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Linux Containers" <containers@lists.osdl.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][DOCUMENTATION] Minimal controller code for a quick start
Date: Thu, 7 Feb 2008 12:49:25 -0800	[thread overview]
Message-ID: <6599ad830802071249g45cb2d6eybd00c1bef07cf5aa@mail.gmail.com> (raw)
In-Reply-To: <1202416137.6274.42.camel@lappy>

On Feb 7, 2008 12:28 PM, Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
>
> While on the subject, could someone document struct cgroup_subsys.

There's documentation for all the methods in Documentation/cgroup.txt

> particular, I've wondered why we have: cgroup_subsys::can_attach() and
> not use a return value in cgroup_subsys::attach()?

We could do in theory do that, but it would make the recovery logic in
cgroup.c:attach_task() more complex - it would have to be able to deal
with undoing a partial attach. It seems simpler to just split it into
two phases, given that most cgroups don't appear to have attachment
conditions anyway.

Paul

  reply	other threads:[~2008-02-07 20:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-07 15:37 Pavel Emelyanov
2008-02-07 20:28 ` Peter Zijlstra
2008-02-07 20:49   ` Paul Menage [this message]
2008-02-07 20:52     ` Peter Zijlstra
2008-02-07 20:50   ` Serge E. Hallyn
2008-02-07 20:45 ` Paul Menage
2008-02-08  8:09   ` Pavel Emelyanov
2008-02-07 20:47 ` Serge E. Hallyn
2008-02-08  9:28   ` Pavel Emelyanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6599ad830802071249g45cb2d6eybd00c1bef07cf5aa@mail.gmail.com \
    --to=menage@google.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=containers@lists.osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xemul@openvz.org \
    --subject='Re: [PATCH][DOCUMENTATION] Minimal controller code for a quick start' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).