LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: Rob Herring <robh@kernel.org>
Cc: myungjoo.ham@samsung.com, kyungmin.park@samsung.com,
	devicetree@vger.kernel.org, ulf.hansson@linaro.org,
	heiko@sntech.de, linux-pm@vger.kernel.org,
	dbasehore@chromium.org, linux-kernel@vger.kernel.org,
	dianders@google.com, groeck@chromium.org, kernel@collabora.com,
	hl@rock-chips.com, Chanwoo Choi <cw00.choi@samsung.com>,
	Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH v2 4/5] dt-bindings: devfreq: rk3399_dmc: remove interrupts as is not required.
Date: Wed, 2 May 2018 18:11:16 +0200	[thread overview]
Message-ID: <66622ef7-6b8a-c524-1f6e-e71ccbc72011@collabora.com> (raw)
In-Reply-To: <20180427200029.elq3drn46nkwbvf2@rob-hp-laptop>

Hi Rob,

Thanks for the review.

On 27/04/18 22:00, Rob Herring wrote:
> On Tue, Apr 24, 2018 at 10:37:41AM +0200, Enric Balletbo i Serra wrote:
>> In ATF we already wait for DDR dvfs finish, so don't need to do this in
>> kernel, so remove the interrupts properties as is not longer required.
> 
> If the hardware has an interrupt, then the DT should have one. The 
> partitioning with ATF shouldn't matter.
> 
> Now, if you want to make ATF remove the interrupt, then maybe that is 
> okay. But it's not clear to me why you'd expose some of the h/w and not 
> all.
> 

Ok, sounds good if I move interrupts to be optional then?

Best regards,
 Enric

>>
>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
>> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
>> ---
>>
>> Changes in v2:
>> - [4/6] Add Reviewed-by Chanwoo Choi.
>>
>>  Documentation/devicetree/bindings/devfreq/rk3399_dmc.txt | 5 -----
>>  1 file changed, 5 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/devfreq/rk3399_dmc.txt b/Documentation/devicetree/bindings/devfreq/rk3399_dmc.txt
>> index 834637c7bae7..e7f0ef9548b7 100644
>> --- a/Documentation/devicetree/bindings/devfreq/rk3399_dmc.txt
>> +++ b/Documentation/devicetree/bindings/devfreq/rk3399_dmc.txt
>> @@ -5,10 +5,6 @@ Required properties:
>>  - devfreq-events:	 Node to get DDR loading, Refer to
>>  			 Documentation/devicetree/bindings/devfreq/event/
>>  			 rockchip-dfi.txt
>> -- interrupts:		 The CPU interrupt number. The interrupt specifier
>> -			 format depends on the interrupt controller.
>> -			 It should be a DCF interrupt. When DDR DVFS finishes
>> -			 a DCF interrupt is triggered.
>>  - clocks:		 Phandles for clock specified in "clock-names" property
>>  - clock-names :		 The name of clock used by the DFI, must be
>>  			 "pclk_ddr_mon";
>> @@ -172,7 +168,6 @@ Example:
>>  	dmc: dmc {
>>  		compatible = "rockchip,rk3399-dmc";
>>  		devfreq-events = <&dfi>;
>> -		interrupts = <GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>;
>>  		clocks = <&cru SCLK_DDRCLK>;
>>  		clock-names = "dmc_clk";
>>  		operating-points-v2 = <&dmc_opp_table>;
>> -- 
>> 2.17.0
>>

  reply	other threads:[~2018-05-02 16:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-24  8:37 [PATCH v2 0/5] devfreq: rk3399_dmc: improve rk3399_dmc driver and it's documentation Enric Balletbo i Serra
2018-04-24  8:37 ` [PATCH v2 1/5] dt-bindings: devfreq: rk3399_dmc: improve binding documentation Enric Balletbo i Serra
2018-04-27 19:55   ` Rob Herring
2018-04-24  8:37 ` [PATCH v2 2/5] dt-bindings: clock: add rk3399 DDR3 standard speed bins Enric Balletbo i Serra
2018-04-27 19:57   ` Rob Herring
2018-04-24  8:37 ` [PATCH v2 3/5] devfreq: rk3399_dmc: remove wait for dcf irq event Enric Balletbo i Serra
2018-04-24  8:37 ` [PATCH v2 4/5] dt-bindings: devfreq: rk3399_dmc: remove interrupts as is not required Enric Balletbo i Serra
2018-04-27 20:00   ` Rob Herring
2018-05-02 16:11     ` Enric Balletbo i Serra [this message]
2018-04-24  8:37 ` [PATCH v2 5/5] devfreq: rk3399_dmc: do not print error when get supply and clk defer Enric Balletbo i Serra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=66622ef7-6b8a-c524-1f6e-e71ccbc72011@collabora.com \
    --to=enric.balletbo@collabora.com \
    --cc=cw00.choi@samsung.com \
    --cc=dbasehore@chromium.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@google.com \
    --cc=groeck@chromium.org \
    --cc=heiko@sntech.de \
    --cc=hl@rock-chips.com \
    --cc=kernel@collabora.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=myungjoo.ham@samsung.com \
    --cc=robh@kernel.org \
    --cc=ulf.hansson@linaro.org \
    --subject='Re: [PATCH v2 4/5] dt-bindings: devfreq: rk3399_dmc: remove interrupts as is not required.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).