LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Shuah Khan <shuah@kernel.org>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Shuah Khan <shuahkh@osg.samsung.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	linux-kselftest <linux-kselftest@vger.kernel.org>,
	Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH 1/1] selftests: Fix lib.mk run_tests target shell script
Date: Fri, 27 Apr 2018 14:42:14 -0600	[thread overview]
Message-ID: <670cba49-7419-5506-de06-05267f0493e9@kernel.org> (raw)
In-Reply-To: <740429490.6175.1524860259330.JavaMail.zimbra@efficios.com>

On 04/27/2018 02:17 PM, Mathieu Desnoyers wrote:
> ----- On Nov 1, 2017, at 6:28 PM, Shuah Khan shuahkh@osg.samsung.com wrote:
> 
>> On 11/01/2017 04:24 PM, Mathieu Desnoyers wrote:
>>> ----- On Nov 1, 2017, at 6:22 PM, Mathieu Desnoyers
>>> mathieu.desnoyers@efficios.com wrote:
>>>
>>>> ----- On Nov 1, 2017, at 5:33 PM, Shuah Khan shuahkh@osg.samsung.com wrote:
>>>>
>>>>> On 10/28/2017 07:46 AM, Mathieu Desnoyers wrote:
>>>>>> Within run_tests target, the whole script needs to be executed within
>>>>>> the same shell and not as separate subshells, so the initial test_num
>>>>>> variable set to 0 is still present when executing "test_num=`echo
>>>>>> $$test_num+1 | bc`;".
>>>>>>
>>>>>> Demonstration of the issue (make run_tests):
>>>>>>
>>>>>> TAP version 13
>>>>>> (standard_in) 1: syntax error
>>>>>> selftests: basic_test
>>>>>> ========================================
>>>>>> ok 1.. selftests: basic_test [PASS]
>>>>>> (standard_in) 1: syntax error
>>>>>> selftests: basic_percpu_ops_test
>>>>>> ========================================
>>>>>> ok 1.. selftests: basic_percpu_ops_test [PASS]
>>>>>> (standard_in) 1: syntax error
>>>>>> selftests: param_test
>>>>>> ========================================
>>>>>> ok 1.. selftests: param_test [PASS]
>>>>>
>>>>> Hi Mathieu,
>>>>>
>>>>> Odd. I don't see the error. I am curious if this specific to
>>>>> env. Can you reproduce this with one of the existing tests,
>>>>> kcmp or breakpoints
>>>>
>>>> Yes, it reproduces:
>>>>
>>>> cd tools/testing/selftests/kcmp
>>>> make run_tests
>>>> gcc -I../../../../usr/include/    kcmp_test.c  -o
>>>> /home/efficios/git/linux-rseq/tools/testing/selftests/kcmp/kcmp_test
>>>> TAP version 13
>>>> (standard_in) 1: syntax error
>>>> selftests: kcmp_test
>>>> ========================================
>>>> ok 1.. selftests: kcmp_test [PASS]
>>>>
>>>> cd tools/testing/selftests/breakpoints
>>>> make run_tests
>>>> gcc     step_after_suspend_test.c  -o
>>>> /home/efficios/git/linux-rseq/tools/testing/selftests/breakpoints/step_after_suspend_test
>>>> gcc     breakpoint_test.c  -o
>>>> /home/efficios/git/linux-rseq/tools/testing/selftests/breakpoints/breakpoint_test
>>>> TAP version 13
>>>> (standard_in) 1: syntax error
>>>> selftests: step_after_suspend_test
>>>> ========================================
>>>> not ok 1.. selftests:  step_after_suspend_test [FAIL]
>>>> (standard_in) 1: syntax error
>>>> selftests: breakpoint_test
>>>> ========================================
>>>> ok 1.. selftests: breakpoint_test [PASS]
>>>>
>>>
>>> The version of "make" on that machine is:
>>>
>>> make --version
>>> GNU Make 3.81
>>> Copyright (C) 2006  Free Software Foundation, Inc.
>>> This is free software; see the source for copying conditions.
>>> There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
>>> PARTICULAR PURPOSE.
>>>
>>> This program built for x86_64-pc-linux-gnu
>>>
>>> (if it helps reproducing)
>>>
>>
>> Yup that's it. I have
>>
>> GNU Make 4.1
>> Built for x86_64-pc-linux-gnu
>> Copyright (C) 1988-2014 Free Software Foundation, Inc.
>> License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
>> This is free software: you are free to change and redistribute it.
>> There is NO WARRANTY, to the extent permitted by law.
>>
>> I will test with your patch and see what happens in my env.
> 
> Hi,
> 
> I still see the problem with v4.17-rc2. Did you have time to
> consider merging my fix ?
> 
> Thanks,
> 
> Mathieu

Sorry for the delay. It slipped through. I will queue this for the next rc. Thanks for
the ping. Hope it applies :)

thanks,
-- Shuah

  reply	other threads:[~2018-04-27 20:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-28 13:46 Mathieu Desnoyers
2017-11-01 21:33 ` Shuah Khan
2017-11-01 22:22   ` Mathieu Desnoyers
2017-11-01 22:24     ` Mathieu Desnoyers
2017-11-01 22:28       ` Shuah Khan
2018-04-27 20:17         ` Mathieu Desnoyers
2018-04-27 20:42           ` Shuah Khan [this message]
2018-04-27 21:05             ` Shuah Khan
2018-04-27 21:33               ` Mathieu Desnoyers
2018-04-27 21:41                 ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=670cba49-7419-5506-de06-05267f0493e9@kernel.org \
    --to=shuah@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=shuahkh@osg.samsung.com \
    --subject='Re: [PATCH 1/1] selftests: Fix lib.mk run_tests target shell script' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).