LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Zengtao (B)" <prime.zeng@hisilicon.com>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: Linuxarm <linuxarm@huawei.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] cpu-topology: Skip the exist but not possible cpu nodes
Date: Sat, 11 Jan 2020 02:03:46 +0000	[thread overview]
Message-ID: <678F3D1BB717D949B966B68EAEB446ED340D6E59@DGGEMM506-MBX.china.huawei.com> (raw)
In-Reply-To: <20200110111622.GA39451@bogus>

> -----Original Message-----
> From: Sudeep Holla [mailto:sudeep.holla@arm.com]
> Sent: Friday, January 10, 2020 7:16 PM
> To: Zengtao (B)
> Cc: Linuxarm; Greg Kroah-Hartman; Rafael J. Wysocki;
> linux-kernel@vger.kernel.org; Sudeep Holla
> Subject: Re: [PATCH] cpu-topology: Skip the exist but not possible cpu
> nodes
> 
> On Wed, Jan 08, 2020 at 01:57:34AM +0000, Zengtao (B) wrote:
> [...]
> 
> > I have the same concern, I have tried to find out some other return
> values
> > But seems not good enough.
> > Maybe it's better to introduce a new function to replace
> of_cpu_node_to_id
> > Any good suggestion?
> >
> 
> No I don't have any. So please drop the extra logic, add a comment on
> -ENODEV return value and use it as needed.

OK, I will address the review comments and send v2.
Thanks 

Zengtao 

      reply	other threads:[~2020-01-11  2:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-02  3:24 Zeng Tao
2020-01-06 18:42 ` Dietmar Eggemann
2020-01-07  1:35   ` Zengtao (B)
2020-01-07 13:12     ` Dietmar Eggemann
2020-01-08  2:01       ` Zengtao (B)
2020-01-07 14:49 ` Sudeep Holla
2020-01-08  1:57   ` Zengtao (B)
2020-01-10 11:16     ` Sudeep Holla
2020-01-11  2:03       ` Zengtao (B) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=678F3D1BB717D949B966B68EAEB446ED340D6E59@DGGEMM506-MBX.china.huawei.com \
    --to=prime.zeng@hisilicon.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=rafael@kernel.org \
    --cc=sudeep.holla@arm.com \
    --subject='RE: [PATCH] cpu-topology: Skip the exist but not possible cpu nodes' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).